New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856232 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 840391



Sign in to add a comment

oopash: Failed connection to ui.ozone.mojom.DrmDevice on startup

Project Member Reported by jamescook@chromium.org, Jun 25 2018

Issue description

CHROMEOS_RELEASE_DESCRIPTION=10816.0.0 (Official Build) dev-channel eve test
chrome ToT c76adeae3e450120bf2f7a47e5a26121087e14e7

Run with --enable-features=OopAsh in /etc/chrome_dev.conf

[20723:20835:0625/091325.780678:ERROR:service_manager.cc(156)] The Service Manager prevented service "ash" from binding interface "ui.ozone.mojom.DrmDevice" in target service "ui". You probably need to update one or more service manifests to ensure that "ui" exposes "ui.ozone.mojom.DrmDevice" through a capability and that "ash" requires that capability from the "ui" service.
[20723:20835:0625/091325.780917:ERROR:service_manager.cc(156)] The Service Manager prevented service "ash" from binding interface "ui.ozone.mojom.DeviceCursor" in target service "ui". You probably need to update one or more service manifests to ensure that "ui" exposes "ui.ozone.mojom.DeviceCursor" through a capability and that "ash" requires that capability from the "ui" service.

Everything works fine on linux-chromeos at this revision.

The weird thing is that I don't expect a "ui service" to run under oopash, just an ash service.

Could there be some low-level ozone code that only runs on device that tries to connect to a "ui service" we don't have anymore?

 
Blocking: 840391

Comment 2 by dxie@google.com, Jun 25 2018

Owner: rjkroege@chromium.org
Status: Assigned (was: Untriaged)
FYI: I tried adding "ozone" to the ash/manifest.json "requires": "ui" section. This isn't sufficient (nor am I certain that is it right).

It makes the above error go away, but then there are complaints about binder_registry not finding implementations of the interfaces.

I'm not sure who is supposed to provide implementations of these interfaces.

Status: Fixed (was: Assigned)
See also issue 850168 "mash: Startup crash in ui::DrmThreadProxy::AddBindingDrmDevice in desktopui_MashLogin autotest"

This issue is fixed by:

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd

commit 6541f861a6a67ccbe4df7a49fde6bbd197ba20bd
Author: James Cook <jamescook@chromium.org>
Date: Mon Jul 09 19:39:53 2018

OopAsh: Fix startup crash on ozone/drm

OopAsh mode (enabled with --enable-features=OopAsh) on CrOS was
crashing at start because the Ozone/Drm DRM and cursor services
were not accessible to the Ash/WS2 host. In this change, the WS2
service is extended to add and bind these interfaces.

Tested by hand by running on device (chell):

	sudo -u chronos ./chrome  --enable-features=OopAsh \
		--user-data-dir=/home/chronos --homedir=/ --login-manager

BUG=850168
TBR=tsepez@chromium.org

Change-Id: I9b6a195f1f5fcce64174eb8e851561c70861dc81
Reviewed-on: https://chromium-review.googlesource.com/1121830
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573408}
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/BUILD.gn
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/DEPS
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/content/content_gpu_interface_provider.cc
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/content/content_gpu_interface_provider.h
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/display/display_color_manager.cc
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/manifest.json
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/ws/ash_gpu_interface_provider.cc
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/ash/ws/ash_gpu_interface_provider.h
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/services/ui/ws2/gpu_interface_provider.h
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/services/ui/ws2/window_service.cc
[modify] https://crrev.com/6541f861a6a67ccbe4df7a49fde6bbd197ba20bd/services/ui/ws2/window_service.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ed74cc7a9cb43ac38a9e7bc8666105e37df909d7

commit ed74cc7a9cb43ac38a9e7bc8666105e37df909d7
Author: James Cook <jamescook@chromium.org>
Date: Wed Jul 11 16:47:56 2018

autotest: Put desktopui_MashLogin back into chrome-informational

chrome --enable-features=Mash no longer uses the startup code path
that was causing flaky crashes. Put it back on the chrome ToT
chrome-informational waterfall.

BUG=chromium:850168, chromium:856232 
TEST=autotest
TBR=stevenjb@chromium.org

Change-Id: Idd90a92644ca5afb81239eb8a22b8bba9b7b532b
Reviewed-on: https://chromium-review.googlesource.com/1133433
Reviewed-by: James Cook <jamescook@chromium.org>
Tested-by: James Cook <jamescook@chromium.org>

[modify] https://crrev.com/ed74cc7a9cb43ac38a9e7bc8666105e37df909d7/client/site_tests/desktopui_MashLogin/control

Sign in to add a comment