New issue
Advanced search Search tips

Issue 856220 link

Starred by 2 users
Status: Fixed
Owner:
kkhorimoto@chromium.org
Closed: Jul 11
Cc:
stkhapugin@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

FullscreenController::ResetModel() should ignore the current scroll event.

Project Member Reported by stkhapugin@chromium.org, Jun 25 2018 
Currently if you call ResetModel() on FullscreenController while a scroll view is decelerating, it will exit from fullscreen and immediately start entering fullscreen again. 
I think the correct behaviour is to ignore the current deceleration. For example, in Safari, if you scroll down on a long page and then tap on the top toolbar, they exit fullscreen and won't re-enter it until a new drag event.

Comment 1 by ghendel@chromium.org, Jun 26 2018

Labels: -Pri-1 Pri-2
Labeling P2 since it's nice to fix

Comment 2 by marq@chromium.org, Jun 27 2018

Labels: Q2

Comment 3 by stkhapugin@chromium.org, Jul 10 

 Issue 862146  has been merged into this issue.

Comment 4 by kkhorimoto@chromium.org, Jul 10

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/466efc849bc657dc33b9ec4121ae5895170a2183

commit 466efc849bc657dc33b9ec4121ae5895170a2183
Author: Kurt Horimoto <kkhorimoto@chromium.org>
Date: Wed Jul 11 21:56:32 2018

[iOS] Ignore remainder of scroll if the FullscreenModel is reset.

This CL adds FullscreenModel::IgnoreRemainderOfCurrentScroll(), which
will ignore broadcasted scroll offsets caused by an in-progress scroll.
This allows FullscreenController::ResetModel() to not immediately get
squashed by residual deceleration from a previous scroll.

Bug:  856220 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6d2823decde1fa2595216aa2b775241043ac944c
Reviewed-on: https://chromium-review.googlesource.com/1132602
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574354}
[modify] https://crrev.com/466efc849bc657dc33b9ec4121ae5895170a2183/ios/chrome/browser/ui/fullscreen/fullscreen_mediator.mm
[modify] https://crrev.com/466efc849bc657dc33b9ec4121ae5895170a2183/ios/chrome/browser/ui/fullscreen/fullscreen_model.h
[modify] https://crrev.com/466efc849bc657dc33b9ec4121ae5895170a2183/ios/chrome/browser/ui/fullscreen/fullscreen_model.mm
[modify] https://crrev.com/466efc849bc657dc33b9ec4121ae5895170a2183/ios/chrome/browser/ui/fullscreen/fullscreen_model_unittest.mm
[modify] https://crrev.com/466efc849bc657dc33b9ec4121ae5895170a2183/ios/chrome/browser/ui/fullscreen/test/fullscreen_model_test_util.h
[modify] https://crrev.com/466efc849bc657dc33b9ec4121ae5895170a2183/ios/chrome/browser/ui/fullscreen/test/fullscreen_model_test_util.mm

Comment 7 by kkhorimoto@chromium.org, Jul 11

Status: Fixed (was: Started)
►

Sign in to add a comment