New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856218 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Suggestion favicons missing on clobber in new windows

Project Member Reported by bklmn@chromium.org, Jun 25 2018

Issue description

1. open new window
2. navigate tab
3. focus omnibox (clobber) 
4. observe missing favicons 
5. hover each suggestion (favicons appear) 

Mac 69.0.3469.2
 
ohJ8fAG9gJL.gif
223 KB View Download

Comment 1 by meh...@chromium.org, Jun 25 2018

Double-report, but different owner: Please see  issue 856237 
Cc: tommycli@chromium.org
 Issue 856237  has been merged into this issue.
Owner: tommycli@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4420fea7a475d148a669ecfcbf635b263364a76

commit f4420fea7a475d148a669ecfcbf635b263364a76
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon Jun 25 21:51:30 2018

Omnibox UI: Fix a missing Invalidate call for async suggestion favicons

Bug report suggests that we are not refreshing the favicons correctly
when they are delivered asynchronously.

This reproduces sporadically, so this CL is a semi-speculative fix.
That being said - there is indeed a missing Invalidate call, so this CL
has a good chance of fixing the bug.

Bug:  856218 
Change-Id: I8a3c83053d765769e4f6a71bffcd947afaa9566e
Reviewed-on: https://chromium-review.googlesource.com/1114154
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570192}
[modify] https://crrev.com/f4420fea7a475d148a669ecfcbf635b263364a76/chrome/browser/ui/views/omnibox/omnibox_result_view.cc

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on mac 10.13.3 using chrome reported version #69.0.3469.2.

Attached a screen cast for reference.

Following are the steps followed to reproduce the issue.
------------
1. opened new window after enabling #top-chrome-md to refresh and enabling #omnibox-new-answer-layout.
2. navigated to new tab.
3. focussed omnibox (clobber) 
4. observed missing favicons 
5. Even upon hovering each suggestion the favicons did not appear.

Note: Same behavior is observed in the latest chrome version #69.0.3473.0 also.

tommycli@ - Could you please check the attached screen cast and please let us know if anything missed from our end.

Thanks...!!
856218.mp4
662 KB View Download
This should be fixed in 3474 or later.

The bug should still be present in 3473 and before.
To reproduce - you will have to be signed in and Syncing.

After opening the new tab, navigate to alexainslie.com, and click on the Omnibox to trigger on-focus suggestions.
Status: Fixed (was: Started)
Fixed. Awaiting verification by TE per c#7.

Sign in to add a comment