http/.../event-listener-breakpoints-webaudio.js in site_per_process_webkit_layout_tests failing on multiple builders |
|||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of penghuang@google.com http/.../event-listener-breakpoints-webaudio.js in site_per_process_webkit_layout_tests failing on multiple builders Builders failed on: - Linux Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests The failed build:
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36818434a5be94d42702991733526ce02c9a6492 commit 36818434a5be94d42702991733526ce02c9a6492 Author: Peng Huang <penghuang@chromium.org> Date: Mon Jun 25 15:50:31 2018 Revert "Fork AudioInputController to the audio service." This reverts commit 040f2ad0aed73dba73467bc500e01c50a3adb628. Reason for revert: <INSERT REASONING HERE> Original change's description: > Fork AudioInputController to the audio service. > > Also migrate the audio service to it. We want to add audio processing > capabilities to the audio service, and the media/ code cannot depend > on services/audio/, so we need the AudioInputController code in the > audio service. There's a very sketched design doc for processing in the > audio service at > https://docs.google.com/document/d/1HJnii4kuBXshVM202TVPJt_9iDmlaCX-VhatjRxRbC4/edit#. > > Bug: 851959 > Change-Id: Icabef727e6d309f86472d2fb401d7383051fa0ae > Reviewed-on: https://chromium-review.googlesource.com/1104464 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570014} TBR=olka@chromium.org,maxmorin@chromium.org Change-Id: I3727f7454ec28718e327335baec3960365afbe93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851959, 856215 Reviewed-on: https://chromium-review.googlesource.com/1113837 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#570050} [modify] https://crrev.com/36818434a5be94d42702991733526ce02c9a6492/services/audio/BUILD.gn [delete] https://crrev.com/26dcff3452ceb026bcb3b56643e85379abaca52b/services/audio/input_controller.cc [delete] https://crrev.com/26dcff3452ceb026bcb3b56643e85379abaca52b/services/audio/input_controller.h [delete] https://crrev.com/26dcff3452ceb026bcb3b56643e85379abaca52b/services/audio/input_controller_unittest.cc [modify] https://crrev.com/36818434a5be94d42702991733526ce02c9a6492/services/audio/input_stream.cc [modify] https://crrev.com/36818434a5be94d42702991733526ce02c9a6492/services/audio/input_stream.h [delete] https://crrev.com/26dcff3452ceb026bcb3b56643e85379abaca52b/services/audio/input_sync_writer.cc [delete] https://crrev.com/26dcff3452ceb026bcb3b56643e85379abaca52b/services/audio/input_sync_writer.h [delete] https://crrev.com/26dcff3452ceb026bcb3b56643e85379abaca52b/services/audio/input_sync_writer_unittest.cc [modify] https://crrev.com/36818434a5be94d42702991733526ce02c9a6492/services/audio/loopback_stream.cc [modify] https://crrev.com/36818434a5be94d42702991733526ce02c9a6492/services/audio/loopback_stream.h [modify] https://crrev.com/36818434a5be94d42702991733526ce02c9a6492/services/audio/loopback_stream_unittest.cc
,
Jun 25 2018
FYI, was also failing on Windows on the commit queue: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/23248
,
Jun 25 2018
Interesting. I wonder what change in audio process service caused the failure of devtool source panel.
,
Jun 26 2018
Hmm, so the failure is 07:02:47.001 32447 [1/1] http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio.js failed unexpectedly (renderer crashed) and the stack trace is crash log for renderer (pid <unknown>): STDOUT: <empty> STDERR: STDERR: DevTools listening on ws://127.0.0.1:33264/devtools/browser/8727d97c-3287-445c-805c-ec0cec4a8375 Not really seeing what's going on here...
,
Jun 26 2018
Oh, the Windows log was better, it shows [4120:4244:0622/195336.910:INFO:media_foundation_video_encode_accelerator_win.cc(353)] Windows versions earlier than 8 are not supported. [2712:4664:0622/195339.426:FATAL:audio_context.cc(316)] Check failed: destination(). Backtrace: base::debug::StackTrace::StackTrace [0x02A93830+32] base::debug::StackTrace::StackTrace [0x02A92FED+13] logging::LogMessage::~LogMessage [0x02AAB8E3+83] blink::AudioContext::baseLatency [0x0512CE94+146] blink::V8AudioContext::baseLatencyAttributeGetterCallback [0x04F0BB70+170] v8::internal::FunctionCallbackArguments::Call [0x020D29B0+608] v8::internal::Builtins::InvokeApiFunction [0x020D158B+4667] v8::internal::Builtins::InvokeApiFunction [0x020D08EA+1434] v8::internal::Object::GetPropertyWithAccessor [0x025278D7+1527] v8::internal::Object::GetProperty [0x02526A06+118] v8::internal::LoadIC::Load [0x0246773E+958] v8::internal::KeyedLoadIC::Load [0x0246D55D+269] v8::internal::Runtime_KeyedLoadIC_Miss [0x02476BE9+905] v8::internal::Runtime_KeyedLoadIC_Miss [0x02476927+199] Still a bit surprising that a change in the service causes WebAudio to crash.
,
Jun 26 2018
Filed issue 856531 about the crash, it's a real bug. Still don't see how my change affected it though.
,
Jun 26 2018
Looks like the test is super flaky https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=event-listener-breakpoints-webaudio.js, and it started before my CL. Maybe issue 856531 is the root cause. I'll reland.
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00f2282b4475a52477c450562b4a62903201a59e commit 00f2282b4475a52477c450562b4a62903201a59e Author: Max Morin <maxmorin@chromium.org> Date: Tue Jun 26 10:39:12 2018 Reland "Fork AudioInputController to the audio service." This is a reland of 040f2ad0aed73dba73467bc500e01c50a3adb628 Test was flaky even before landing this. Original change's description: > Fork AudioInputController to the audio service. > > Also migrate the audio service to it. We want to add audio processing > capabilities to the audio service, and the media/ code cannot depend > on services/audio/, so we need the AudioInputController code in the > audio service. There's a very sketched design doc for processing in the > audio service at > https://docs.google.com/document/d/1HJnii4kuBXshVM202TVPJt_9iDmlaCX-VhatjRxRbC4/edit#. > > Bug: 851959 > Change-Id: Icabef727e6d309f86472d2fb401d7383051fa0ae > Reviewed-on: https://chromium-review.googlesource.com/1104464 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570014} Tbr: Olka Bug: 851959, 856215 Change-Id: I2e99e92937f8ccd73fb2ea3bd09d4175ab21419d Reviewed-on: https://chromium-review.googlesource.com/1114618 Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570366} [modify] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/BUILD.gn [add] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_controller.cc [add] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_controller.h [add] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_controller_unittest.cc [modify] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_stream.cc [modify] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_stream.h [add] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_sync_writer.cc [add] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_sync_writer.h [add] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/input_sync_writer_unittest.cc [modify] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/loopback_stream.cc [modify] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/loopback_stream.h [modify] https://crrev.com/00f2282b4475a52477c450562b4a62903201a59e/services/audio/loopback_stream_unittest.cc
,
Jun 26 2018
http/tests/devtools/sources/debugger-breakpoints/event-listener-breakpoints-webaudio.js flaked for me in https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/81157 09:29:40.501 20749 [21248:775:0626/092912.217432:FATAL:audio_context.cc(316)] Check failed: destination(). 09:29:40.501 20749 0 Content Shell Framework 0x0000000117a3288c base::debug::StackTrace::StackTrace(unsigned long) + 28 09:29:40.501 20749 1 Content Shell Framework 0x000000011795c5cf logging::LogMessage::~LogMessage() + 223 09:29:40.501 20749 2 Content Shell Framework 0x000000011b4a70a7 blink::AudioContext::baseLatency() const + 167 09:29:40.501 20749 3 Content Shell Framework 0x000000011af82b29 blink::V8AudioContext::baseLatencyAttributeGetterCallback(v8::FunctionCallbackInfo<v8::Value> const&) + 25 09:29:40.501 20749 4 Content Shell Framework 0x0000000115aa62cc v8::internal::FunctionCallbackArguments::Call(v8::internal::CallHandlerInfo*) + 828 09:29:40.501 20749 5 Content Shell Framework 0x0000000115aa456e v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, v8::internal::BuiltinArguments) + 958 09:29:40.501 20749 6 Content Shell Framework 0x0000000115aa32d0 v8::internal::Builtins::InvokeApiFunction(v8::internal::Isolate*, bool, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::Object>, int, v8::internal::Handle<v8::internal::Object>*, v8::internal::Handle<v8::internal::HeapObject>) + 2112 09:29:40.501 20749 7 Content Shell Framework 0x0000000116105208 v8::internal::Object::GetPropertyWithAccessor(v8::internal::LookupIterator*) + 1592 09:29:40.501 20749 8 Content Shell Framework 0x0000000115ff714b v8::internal::LoadIC::Load(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Name>) + 1451 09:29:40.502 20749 9 Content Shell Framework 0x0000000115ffdcd9 v8::internal::KeyedLoadIC::Load(v8::internal::Handle<v8::internal::Object>, v8::internal::Handle<v8::internal::Object>) + 249 09:29:40.502 20749 10 Content Shell Framework 0x000000011600790a v8::internal::__RT_impl_Runtime_KeyedLoadIC_Miss(v8::internal::Arguments, v8::internal::Isolate*) + 202 09:29:40.502 20749 11 Content Shell Framework 0x000000011687faf5 v8_Default_embedded_blob_ + 2665493 09:29:40.502 20749
,
Jun 26 2018
This is a WebAudio bug. Fix coming soon.
,
Jun 28 2018
Issue 857414 has been merged into this issue.
,
Jun 28 2018
Note I've disabled the flaky test (see duplicated bug).
,
Jun 28 2018
,
Jun 28 2018
,
Jul 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b44e895955f62d790a37a723fab384c30178b496 commit b44e895955f62d790a37a723fab384c30178b496 Author: Hongchan Choi <hongchan@chromium.org> Date: Mon Jul 02 16:01:52 2018 Enable event-listener-breakpoints-webaudio.js test This is a follow-up CL of https://chromium-review.googlesource.com/c/chromium/src/+/1115516. TBR=rtoy@ Bug: 856215 Change-Id: Ib2836d831968795eac6a95eae6148469af69d15d Reviewed-on: https://chromium-review.googlesource.com/1121209 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#571907} [modify] https://crrev.com/b44e895955f62d790a37a723fab384c30178b496/third_party/WebKit/LayoutTests/TestExpectations
,
Jul 2
The issue has been fixed and the test expectation was also updated. I'll monitor the dashboard until tomorrow.
,
Jul 3
The test does not seem to be flaky anymore.
,
Jul 3
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by penghuang@chromium.org
, Jun 25 2018Status: Assigned (was: Available)