Ignore unknown getUserMedia constraints. |
|||
Issue descriptiongoogBeamforming and googArrayGeometry is being removed. We should update media_constraints_impl.cc to ignore these (and any other unknown) constraints, in accordance with the spec. In the meantime, we have to keep a few references to googBeamforming and googArrayGeometry around to avoid breaking apps that are disabling beamforming.
,
Jul 27
,
Aug 27
The old-style constraints have always rejected on unknown constraint names in mandatory constraints. They are not specified in the standard, so the spec has no power over them. If we remove the special cases for googBeamforming and googArrayGeometry, clients that previously worked will start failing. If we remove the error return, clients that previously used this to probe for unimplemeted constraints will start seeing their detection code break. Suggestion: Add an UMA counter to the "unimplemented" branch, and let it remain in the code. (Also add an UMA counter to the "error" and "unimplemented but ignored" branches at the end of the ParseOldStyleNames function)
,
Sep 12
We have implemented this in accordance to #3 and that is enough to consider this work as finished. In a later stage we will hopefully remove old-style constraints completely, but no further work is needed for googBeamforming and googArrayGeometry. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jun 25 2018