Key icon resource not available for Password Accessory sheet in Kitkat (and below) |
||||
Issue descriptionAccording to http://crash/browse?stbtiq=464986208d0eef05#0, the ic_vpn_key_grey.xml cannot be loaded properly on Kitkat and earlier Android versions. The stacktrace below shows that the loading itself failed. Usually because the drawable tag <vector> is found invalid although the used |VectorDrawableCompat.create()| should support that. Shortened Stack Trace: Thread 49android.content.res.Resources$NotFoundException: File res/drawable/ic_vpn_key_grey.xml from drawable resource ID #0x7f080211 at android.content.res.Resources.loadDrawable (Resources.java:1951 ) at android.content.res.Resources.getDrawable (Resources.java:672 ) at org.chromium.chrome.browser.autofill.keyboard_accessory.PasswordAccessorySheetCoordinator$1.getIcon (PasswordAccessorySheetCoordinator.java:67 ) Caused by: org.xmlpull.v1.XmlPullParserException: Binary XML file line #6: invalid drawable tag vector at android.graphics.drawable.Drawable.createFromXmlInner (Drawable.java:877 ) at android.graphics.drawable.Drawable.createFromXml (Drawable.java:818 ) at android.content.res.Resources.loadDrawable (Resources.java:1948 ) at android.content.res.Resources.getDrawable (Resources.java:672 ) at org.chromium.chrome.browser.autofill.keyboard_accessory.PasswordAccessorySheetCoordinator$1.getIcon (PasswordAccessorySheetCoordinator.java:67 ) at org.chromium.chrome.browser.autofill.keyboard_accessory.KeyboardAccessoryViewBinder$TabViewBinder.updateAllTabs (KeyboardAccessoryViewBinder.java:93 )
,
Jun 25 2018
Issue 856258 has been merged into this issue.
,
Jun 25 2018
,
Jun 25 2018
,
Jun 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c1d162157220cbac0e42d91c9fe6422d21508a47 commit c1d162157220cbac0e42d91c9fe6422d21508a47 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Tue Jun 26 16:30:02 2018 [Android, Crash] Fix for key icon drawable in accessory bar This CL tries to address the kitkat and earlier crashes due to a parsing error of a vector graphic by replacing VectorDrawableCompat with AppCompatResources. Bug: 856175 Change-Id: I987d930be1164f8c9e33025d733f928d3ac7ff1f Reviewed-on: https://chromium-review.googlesource.com/1115122 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570425} [modify] https://crrev.com/c1d162157220cbac0e42d91c9fe6422d21508a47/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
,
Jun 26 2018
A more reliable method is used to read the vector graphic. In accordance with the solution to similar crashes in earlier versions, this should do the trick. Alternatively, another CL is ready that would fix this issue for the short-term (https://crrev.com/c/1114819). If new problems related to the ic_vpn_key_grey resource occur, please reopen this bug. Otherwise, I'd appreciate a verification. |
||||
►
Sign in to add a comment |
||||
Comment 1 by fhorschig@chromium.org
, Jun 25 2018