Since it's dll-only, maybe asan sets a different errno than the one we're checking here: https://cs.chromium.org/chromium/src/third_party/crashpad/crashpad/util/stdlib/string_number_conversion.cc?g=0&l=135 ?

(strtol interceptor: http://llvm-cs.pcc.me.uk/projects/compiler-rt/lib/asan/asan_interceptors.cc#475 )

I'm having dejavu, I think we filed this before, and I basically disabled the entire crashpad_tests suite on ASan bots as a result.

The problem is that we intercept strtoul in ntdll.dll, ucrtbase.dll, and a bunch of other places, and asan delegates to the first (or last, I forget) implementation it finds. ntdll's strtoul doesn't set errno (or maybe not the right errno) so it doesn't work.

Thanks, with that information I was able to find  bug 782454  where you disabled, which via  bug 782907  redirects to bug 845011, but that doesn't have the StringNumberConversion failure.

Root cause https://bugs.llvm.org/show_bug.cgi?id=35137

StringNumberConversion.StringToInt is the only failing crashpad_tests test -- maybe we should disable just that one.

I.e. reinstantiate https://chromium.googlesource.com/chromium/src/+/0e16a775e9e8a6133a074ec01b558ce17d2f93a7%5E%21/#F0

Disabling here: https://chromium-review.googlesource.com/c/chromium/src/+/1113664

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/339ab9726bcba21566853bf88ca9c6fbcd885370

commit 339ab9726bcba21566853bf88ca9c6fbcd885370
Author: Nico Weber <thakis@chromium.org>
Date: Mon Jun 25 20:36:58 2018

Don't run string_number_conversion_test.cc on win/asan/dll again.

Reapplies https://chromium-review.googlesource.com/c/chromium/src/+/757880,
which got removed in https://chromium-review.googlesource.com/c/762380/ when
we removed all crashpad_tests from all win/asan bots.  crashpad_tests runs
on the win/asan bots again, so this one test needs to be disabled again.

(See bug; root cause bugs.llvm.org/PR35137)

Bug: 856174
Change-Id: I0796efd9ba306ea5a304a5ae85eeb4af9eec656e
Reviewed-on: https://chromium-review.googlesource.com/1113664
Reviewed-by: Reid Kleckner <rnk@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570163}
[modify] https://crrev.com/339ab9726bcba21566853bf88ca9c6fbcd885370/third_party/crashpad/crashpad/util/BUILD.gn

The bot is currently failing to generate build files in this config. Fix: https://chromium-review.googlesource.com/c/chromium/src/+/1245463

The following revision refers to this bug:
  https://chromium.googlesource.com/crashpad/crashpad.git/+/7786acf0d7a2e274da5eb1200927d6edf6faec07

commit 7786acf0d7a2e274da5eb1200927d6edf6faec07
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Sep 26 17:01:52 2018

win: move string_number_conversion_test asan/dll disabling into the win clause

This fixes the upstreaming of https://chromium-review.googlesource.com/c/chromium/src/+/1113664

Bug: chromium:856174
Change-Id: I88cf6aeecef60e4eaf5c14dc9a66f0409255ccac
Reviewed-on: https://chromium-review.googlesource.com/1245481
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/7786acf0d7a2e274da5eb1200927d6edf6faec07/util/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e9a65339d459a8f4d67e1ef83a9acef6ba923fc

commit 9e9a65339d459a8f4d67e1ef83a9acef6ba923fc
Author: Hans Wennborg <hans@chromium.org>
Date: Wed Sep 26 17:22:48 2018

crashpad: Fix gn failure for Win ASan component builds

The builds were failing like:

ERROR at //third_party/crashpad/crashpad/util/BUILD.gn:657:20: Item not found
      sources -= [ "stdlib/string_number_conversion_test.cc" ]
                   ^----------------------------------------
You were trying to remove "stdlib/string_number_conversion_test.cc"
from the list but it wasn't there.
See //chrome/installer/setup/BUILD.gn:114:7: which caused the file to be included.
      "//third_party/crashpad/crashpad/util",
      ^-------------------------------------
GN gen failed: 1

thakis excluded this file in https://chromium-review.googlesource.com/1113664

jperaza then upstreamed that in https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1195567
but put it outside the crashpad_is_win clause

When the upstream change was rolled into chromium in https://chromium-review.googlesource.com/c/chromium/src/+/1195670
we ended up with the file exclusion *both* in the crashpad_is_win_clause and outside it, causing this gn error.

Bug: 856174
Change-Id: I5b812567e6a9be54ce622b9a221b61dc6a27f1b6
Reviewed-on: https://chromium-review.googlesource.com/1245463
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594363}
[modify] https://crrev.com/9e9a65339d459a8f4d67e1ef83a9acef6ba923fc/third_party/crashpad/crashpad/util/BUILD.gn