New issue
Advanced search Search tips

Issue 856169 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

browser_tests PDFExtensionHitTestTest.MouseLeave/1 fails on many platforms

Project Member Reported by thakis@chromium.org, Jun 25 2018

Issue description

https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/

e.g. https://ci.chromium.org/buildbot/chromium.clang/CrWinAsan/828

[ RUN      ] PDFExtensionHitTestTest.MouseLeave/1
[6888:6560:0625/050856.787:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[6888:2684:0625/050857.040:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=PDFExtensionHitTestTest.MouseLeave/1 --no-sandbox --single_process --test-launcher-bot-mode --test-launcher-filter-file=../../testing/buildbot/filters/viz.browser_tests.filter --test-launcher-output="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir1444_6115\results1444_13475\test_results.xml" --test-launcher-summary-output="C:\b\s\w\io20jokd\output.json" --user-data-dir="C:\Users\CHROME~1\AppData\Local\Temp\scoped_dir1444_6115\d1444_23260" --disable-offline-auto-reload --site-per-process --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=90 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1,VizDisplayCompositor,VizHitTestDrawQuad --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
[6888:7088:0625/050858.995:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[6888:2684:0625/050901.072:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
../../chrome/browser/pdf/pdf_extension_test.cc(1714): error: Expected equality of these values:
  1
  enter_count
    Which is: 2
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF67E789714+214] (C:\b\c\b\CrWinAsan\src\third_party\googletest\src\googletest\src\gtest.cc:810)
	testing::internal::AssertHelper::operator= [0x00007FF67E788695+265] (C:\b\c\b\CrWinAsan\src\third_party\googletest\src\googletest\src\gtest.cc:386)
	PDFExtensionHitTestTest_MouseLeave_Test::RunTestOnMainThread [0x00007FF67C3EF76F+5565] (C:\b\c\b\CrWinAsan\src\chrome\browser\pdf\pdf_extension_test.cc:1714)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF6858AC3A5+1599] (C:\b\c\b\CrWinAsan\src\content\public\test\browser_test_base.cc:409)
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF6896F2137+12839] (C:\b\c\b\CrWinAsan\src\chrome\browser\chrome_browser_main.cc:1996)
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF6896EEAC6+566] (C:\b\c\b\CrWinAsan\src\chrome\browser\chrome_browser_main.cc:1380)
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF680D2F9AF+385] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main_loop.cc:967)
	content::StartupTaskRunner::RunAllTasksNow [0x00007FF681B71E76+284] (C:\b\c\b\CrWinAsan\src\content\browser\startup_task_runner.cc:43)
	content::BrowserMainLoop::CreateStartupTasks [0x00007FF680D2AE22+1812] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main_loop.cc:879)
	content::BrowserMainRunnerImpl::Initialize [0x00007FF680D375E9+593] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main_runner_impl.cc:148)
	content::BrowserMain [0x00007FF680D242B7+579] (C:\b\c\b\CrWinAsan\src\content\browser\browser_main.cc:47)
	content::RunBrowserProcessMain [0x00007FF6853C9271+485] (C:\b\c\b\CrWinAsan\src\content\app\content_main_runner_impl.cc:608)
	content::ContentMainRunnerImpl::Run [0x00007FF6853CB080+1524] (C:\b\c\b\CrWinAsan\src\content\app\content_main_runner_impl.cc:961)
	service_manager::Main [0x00007FF686EE3097+3639] (C:\b\c\b\CrWinAsan\src\services\service_manager\embedder\main.cc:459)
	content::ContentMain [0x00007FF6853C8F67+279] (C:\b\c\b\CrWinAsan\src\content\app\content_main.cc:19)
	content::BrowserTestBase::SetUp [0x00007FF6858AB554+4172] (C:\b\c\b\CrWinAsan\src\content\public\test\browser_test_base.cc:325)
	InProcessBrowserTest::SetUp [0x00007FF68579E19B+1717] (C:\b\c\b\CrWinAsan\src\chrome\test\base\in_process_browser_test.cc:248)
[6888:2684:0625/050909.891:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[6888:2684:0625/050909.891:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] PDFExtensionHitTestTest.MouseLeave/1, where GetParam() = true (13783 ms)



jonross, does Viz have a triage rotation, and if not are there more people than just you I can give these bugs to?

If someone can look at this and fix, great, but if it takes a while we should probably disable the test on win/asan/viz for now.
 
Cc: jonr...@chromium.org
Owner: wjmaclean@chromium.org
Sorry was OOO.

No formal triage rotation, but there should be monitoring of the Component tag you used.

Assigning to wjmaclean@ to help triage further as they added the test in question.

It looks like the expectation is failing on win/asan builds, which run slower.
Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Blocking: 869973
This blocks the main waterfall win/asan effort.
Summary: browser_tests PDFExtensionHitTestTest.MouseLeave/1 fails on win/asan (was: viz_browser_tests PDFExtensionHitTestTest.MouseLeave/1 fails on win/asan)
Can also fail in regular browser_tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win-asan/29

Better stack from there:

[ RUN      ] PDFExtensionHitTestTest.MouseLeave/0
[6432:5712:0819/123220.022:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[6432:7580:0819/123220.179:WARNING:chrome_browser_main_win.cc(641)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --disable-gpu-process-for-dx12-vulkan-info-collection --gtest_also_run_disabled_tests --gtest_filter=PDFExtensionHitTestTest.MouseLeave/0 --no-sandbox --single_process --test-launcher-bot-mode --test-launcher-output="C:\b\s\w\it3e8tzy\scoped_dir5784_12635\results5784_12141\test_results.xml" --test-launcher-summary-output="C:\b\s\w\iowd7tjq\output.json" --user-data-dir="C:\b\s\w\it3e8tzy\scoped_dir5784_12635\d5784_25026" --disable-offline-auto-reload --site-per-process --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=90 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2,VizHitTestDrawQuad --disable-gpu-process-for-dx12-vulkan-info-collection --flag-switches-begin --flag-switches-end --file-url-path-alias="/gen=C:\b\s\w\ir\out\Release_x64\gen" --restore-last-session about:blank
[6432:6252:0819/123222.120:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
[6432:7580:0819/123223.755:INFO:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
../../chrome/browser/pdf/pdf_extension_test.cc(1828): error: Expected equality of these values:
  1
  enter_count
    Which is: 2
Stack trace:
Backtrace:
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x00007FF713F84B74+214] (C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:825)
	testing::internal::AssertHelper::operator= [0x00007FF713F83AF5+265] (C:\b\swarming\w\ir\cache\builder\src\third_party\googletest\src\googletest\src\gtest.cc:401)
	PDFExtensionHitTestTest_MouseLeave_Test::RunTestOnMainThread [0x00007FF711B283F0+5596] (C:\b\swarming\w\ir\cache\builder\src\chrome\browser\pdf\pdf_extension_test.cc:1828)
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x00007FF71BC8DB16+1650] (C:\b\swarming\w\ir\cache\builder\src\content\public\test\browser_test_base.cc:406)
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x00007FF71F6E8773+13027] (C:\b\swarming\w\ir\cache\builder\src\chrome\browser\chrome_browser_main.cc:2000)
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x00007FF71F6E5035+555] (C:\b\swarming\w\ir\cache\builder\src\chrome\browser\chrome_browser_main.cc:1384)
	content::BrowserMainLoop::PreMainMessageLoopRun [0x00007FF7168613B3+385] (C:\b\swarming\w\ir\cache\builder\src\content\browser\browser_main_loop.cc:1024)
	content::StartupTaskRunner::RunAllTasksNow [0x00007FF7177838F2+284] (C:\b\swarming\w\ir\cache\builder\src\content\browser\startup_task_runner.cc:43)
	content::BrowserMainLoop::CreateStartupTasks [0x00007FF71685C15B+1825] (C:\b\swarming\w\ir\cache\builder\src\content\browser\browser_main_loop.cc:936)
	content::BrowserMainRunnerImpl::Initialize [0x00007FF716869565+567] (C:\b\swarming\w\ir\cache\builder\src\content\browser\browser_main_runner_impl.cc:141)
	content::BrowserMain [0x00007FF716855695+533] (C:\b\swarming\w\ir\cache\builder\src\content\browser\browser_main.cc:43)
	content::RunBrowserProcessMain [0x00007FF71B0C737C+404] (C:\b\swarming\w\ir\cache\builder\src\content\app\content_main_runner_impl.cc:536)
	content::ContentMainRunnerImpl::Run [0x00007FF71B0C9173+1827] (C:\b\swarming\w\ir\cache\builder\src\content\app\content_main_runner_impl.cc:888)
	service_manager::Main [0x00007FF71D1C9DEE+3878] (C:\b\swarming\w\ir\cache\builder\src\services\service_manager\embedder\main.cc:472)
	content::ContentMain [0x00007FF71B0C70C9+265] (C:\b\swarming\w\ir\cache\builder\src\content\app\content_main.cc:19)
	content::BrowserTestBase::SetUp [0x00007FF71BC8CC07+4367] (C:\b\swarming\w\ir\cache\builder\src\content\public\test\browser_test_base.cc:322)
	InProcessBrowserTest::SetUp [0x00007FF71B54C334+1662] (C:\b\swarming\w\ir\cache\builder\src\chrome\test\base\in_process_browser_test.cc:251)
[6432:7580:0819/123233.745:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[6432:7580:0819/123233.746:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] PDFExtensionHitTestTest.MouseLeave/0, where GetParam() = false (14733 ms)
Labels: Stability-Memory-AddressSanitizer
wjmaclean: The test is still flaky on win/asan, but the test also no longer runs as of https://chromium-review.googlesource.com/1180763 . I can either mark this fixed, or you can use the bug for re-enabling the test and we can remove the blocking relationship to  issue 869973  -- up to you.
Blocking: -869973
Let's leave it open for now as a reminder to keep trying to find the underlying problem here. Thanks!
Cc: keishi@chromium.org
 Issue 892484  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67be413d156f1af34aaf90985ec239fc2b29ce4f

commit 67be413d156f1af34aaf90985ec239fc2b29ce4f
Author: Greg Thompson <grt@chromium.org>
Date: Thu Nov 29 11:55:11 2018

Disable PDFExtensionHitTestTest.MouseLeave/* due to flakes.

BUG=856169
TBR=grt@chromium.org

Change-Id: I2e9cf461d6003b2e1a85129ad52b8d2157685b15
Reviewed-on: https://chromium-review.googlesource.com/c/1354449
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612154}
[modify] https://crrev.com/67be413d156f1af34aaf90985ec239fc2b29ce4f/chrome/browser/pdf/pdf_extension_test.cc

Summary: browser_tests PDFExtensionHitTestTest.MouseLeave&#x2f;1 fails on many platforms (was: browser_tests PDFExtensionHitTestTest.MouseLeave&#x2f;1 fails on win/asan)
Some other failures:
https://chromium-swarm.appspot.com/task?id=417765d238d2e010&refresh=10&show_raw=1
https://chromium-swarm.appspot.com/task?id=4177af03ccbef810&refresh=10&show_raw=1

The flakiness dashboard shows failures pretty much everywhere.
grt@ - The example links only show the test failing for /0, yet you indicate /* ... are there examples of it failing for /1 or /2 ? If not, it should only be disabled for /0.

Sign in to add a comment