Blink Scheduler: Prioritize same-origin frames over cross-origin ones. |
|||||||||
Issue descriptionExperiment with different priorities of frame task queues depending on their origin type. In particular, (during loading or at all times) 1- Increase the priority of the loading task queue to high for same-origin frame tasks. 2- Decrease the priority of cross origin task queues to low.
,
Jul 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae commit bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae Author: Farah Charab <farahcharab@google.com> Date: Mon Jul 23 21:11:08 2018 Scheduler: Experiment with setting priorities based on frame origin. Set the priority of same-origin loading task to high and the priority of cross-origin tasks to low depending on the feature enabled. Bug: 856158 Change-Id: I5bc2e17cf512ccae0cdd7a62d1afc61cc5b53cb7 Reviewed-on: https://chromium-review.googlesource.com/1112252 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#577256} [modify] https://crrev.com/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae/third_party/blink/renderer/platform/scheduler/child/features.h [modify] https://crrev.com/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc [modify] https://crrev.com/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
,
Aug 2
,
Aug 3
This is a non-risky internal scheduling change which is not user-facing and with no UX/privacy/security implications. It has been submitted since July 23, and no Crashes have been reported.
,
Aug 3
The bug is marked as P3 or Feature. It should not be merged as M69 is in beta. Please contact the approriate milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
,
Aug 3
,
Aug 3
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 3
Approving merge to M69 branch 3497 based on comment #4. Please merge ASAP. Thank you.
,
Aug 5
Please merge your change to M69 branch 3497 by 4:00 PM PT, Monday (08/06) so we can pick it up for next week M69 beta release. Thank you.
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8 commit 1028eac6a0b1749c0a3b0b14b1d14af5e75060a8 Author: Alexander Timin <altimin@chromium.org> Date: Mon Aug 06 10:17:52 2018 Scheduler: Experiment with setting priorities based on frame origin. Set the priority of same-origin loading task to high and the priority of cross-origin tasks to low depending on the feature enabled. TBR=farahcharab@google.com (cherry picked from commit bf2c477e5d5171d1e2c7d0f73b1f47e7e2d9e3ae) Bug: 856158 Change-Id: I5bc2e17cf512ccae0cdd7a62d1afc61cc5b53cb7 Reviewed-on: https://chromium-review.googlesource.com/1112252 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by: Robert Kaplow (OOO until 0730) <rkaplow@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577256} Reviewed-on: https://chromium-review.googlesource.com/1163514 Cr-Commit-Position: refs/branch-heads/3497@{#412} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8/testing/variations/fieldtrial_testing_config.json [modify] https://crrev.com/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8/third_party/blink/renderer/platform/scheduler/child/features.h [modify] https://crrev.com/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc [modify] https://crrev.com/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc [modify] https://crrev.com/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc [modify] https://crrev.com/1028eac6a0b1749c0a3b0b14b1d14af5e75060a8/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by farahcharab@chromium.org
, Jun 25 2018Summary: Blink Scheduler: Prioritize same-origin frames over cross-origin ones. (was: Blink Scheduler: Prioritize same-origin frames over cross-origin.)