New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 856156 link

Starred by 3 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Jul 12
Cc:
█ sindhu.chelamcherla@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Unwanted blue box is seen on clicking between Pages radio buttons

Project Member Reported by sindhu.chelamcherla@chromium.org, Jun 25 2018 
Chrome Version: 69.0.3472.0
OS:  Win10, MacOS 10.13.3, Debian

Pre-condition: Enable #enable-new-print-preview flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, hit ctrl+p for print preview 
(2) Click and hold space between radio buttons of Pages section

Expected: No unwanted focus should be seen 
Actual: Instead blue focus ring is seen on second radio button when you click on space between pages radio buttons.

This issue is seen from introduction of enable-new-print-preview flag in M-67.

@rbpotter: Please confirm the issue and help in re-assigning if this is not related to your change.

Thanks!
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f219a6402897c1ad37927cfefa29b6023c4a2fb1

commit f219a6402897c1ad37927cfefa29b6023c4a2fb1
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Jun 26 20:41:44 2018

Print Preview: Remove focus outline from wrapper

Bug:  856156 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I0b9470bdd7318300f68d3df615c3b21955d156b8
Reviewed-on: https://chromium-review.googlesource.com/1115206
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570519}
[modify] https://crrev.com/f219a6402897c1ad37927cfefa29b6023c4a2fb1/chrome/browser/resources/print_preview/new/pages_settings.html

Comment 2 by sindhu.chelamcherla@chromium.org, Jun 27 2018

Labels: TE-Verified-M69 TE-Verified-69.0.3474.0
Able to reproduce this issue on reported version hence verifying the fix on latest canary 69.0.3474.0 using Mac 10.13.3, Windows 10 and debian.

Now on clicking space between radio buttons no blue focus outline is seen. Attaching screencast for reference.

As fix is working as expected adding Verified labels.

Thanks!
856156_M69.mp4
944 KB View Download

Comment 3 by rbpotter@chromium.org, Jul 12

Status: Fixed (was: Assigned)
►

Sign in to add a comment