Should show a tooltip over overflow button |
|||||||
Issue descriptionChrome Version: 67.0.3396.99/10575.58.0 stable channel Daisy,Candy,Cyan OS: Chrome What steps will reproduce the problem? 1)Click on App launcher and pin more than 16 apps to shelf -> At shelf we can see upto 15 apps and for other apps to view there will be Upward arrow 2)Hover on Upward arrow and observe for tool tip such as 'Expand Shelf' (Please refer Video) Note : Click on Expand or Upward arrow icon to view other remaining apps and now hover mouse pointer on Downwards arrow and observe for tool tip such as 'Collapse Shelf' Expected: Tool tip should be seen on hovering mouse pointer on Upward arrow such as 'Expand Shelf' Actual: Instead No Tool Tip is seen This is Non-Regression issue seen from M-62 Note: Issue is also seen in Latest M-61
,
Oct 8
,
Dec 27
Sébastien, do you think we should show a tooltip over the overflow button? If so, what should it read?
,
Dec 27
(Please reassign to me afterwards. Thank :-) )
,
Dec 27
s
,
Dec 27
what's the current a11y label for this? We might just want to match what the screen reader reads.
,
Jan 14
,
Jan 15
,
Jan 15
FYI fix sent out as CL 1410425.
,
Jan 18
(5 days ago)
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f804d91f51b3fb783f7894ed06710777f3958b2 commit 2f804d91f51b3fb783f7894ed06710777f3958b2 Author: Manu Cornet <manucornet@chromium.org> Date: Fri Jan 18 03:59:47 2019 CrOS Shelf: Show a tooltip for the overflow button * Include the overflow button in the "union of visible shelf item bounds" so that tooltips don't stutter when hovering over all shelf items, including the overflow button. * Slight refactor of the logic to provide tooltip texts for buttons. * For the "hover preview" feature, don't attempt to build up a list of "open windows" for something that isn't an app shortcut. Bug: 856130 Change-Id: Ia84f4e40cadbc5cdcccc712c5c1d2a5144fdf138 Reviewed-on: https://chromium-review.googlesource.com/c/1410425 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#624000} [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_app_button.cc [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_app_button.h [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_button.cc [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_button.h [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_tooltip_manager.cc [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_view.cc [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_view.h [modify] https://crrev.com/2f804d91f51b3fb783f7894ed06710777f3958b2/ash/shelf/shelf_view_unittest.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by newcomer@chromium.org
, Jun 25 2018