New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 856127 link

Starred by 1 user
Status: Fixed
Owner:
ioanap@chromium.org
Closed: Jul 17
Cc:
█ nepper@chromium.org
fhorschig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Incorrect back button behavior for keyboard accessory Sheet

Project Member Reported by fhorschig@chromium.org, Jun 25 2018 
The keyboard accessory sheet should behave like keyboard in regards to the back button:
 - The back button should close the sheet and not be handled by the content area (must have)
 - The back button should keep the keyboard-typical down arrow symbol instead of reverting to the back button (should have unless this is restricted by Android)

Comment 1 by fhorschig@chromium.org, Jun 25 2018

Blocking: 853794

Comment 2 by fhorschig@chromium.org, Jul 9

Cc: fhorschig@chromium.org
Owner: ioanap@chromium.org

Comment 3 by ioanap@chromium.org, Jul 9

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abb1d1d0c376676179bfbf229e2cd2a152e7fc70

commit abb1d1d0c376676179bfbf229e2cd2a152e7fc70
Author: Ioana Pandele <ioanap@chromium.org>
Date: Mon Jul 16 16:50:18 2018

Close the accessory sheet for passwords when the back button is pressed

If the bottom sheet is open, pressing the Android back button should
dismiss the accessory sheet as well as the keyboard accessory bar.

Bug:  856127 
Change-Id: If8e9862ed1d1e404bd4afa23b8d62f572674317c
Reviewed-on: https://chromium-review.googlesource.com/1129236
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575307}
[modify] https://crrev.com/abb1d1d0c376676179bfbf229e2cd2a152e7fc70/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/abb1d1d0c376676179bfbf229e2cd2a152e7fc70/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/abb1d1d0c376676179bfbf229e2cd2a152e7fc70/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/abb1d1d0c376676179bfbf229e2cd2a152e7fc70/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/abb1d1d0c376676179bfbf229e2cd2a152e7fc70/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/abb1d1d0c376676179bfbf229e2cd2a152e7fc70/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java

Comment 5 by ioanap@chromium.org, Jul 17

Status: Fixed (was: Started)
►

Sign in to add a comment