Issue metadata
Sign in to add a comment
|
Regression:Focus Ring appears bigger in size than expected around the passphrase textbox and submit button.
Reported by
shruti.j...@etouch.net,
Jun 25 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version : 69.0.3472.0 (Official Build) Revision:c98da5eedd07a2e61d1a982bb9dab46e437946cf-refs/branch-heads/3472@{#1} (32/64 bit) OS: Windows(7,8,8.1,10), Mac OS X(10.12.6,10.13.1,10.13.6). Steps to reproduce: 1.Launch Chrome and 'Sign in to chrome' from 'Avtar' with a valid 'Pass-Phrase' enabled account. 2.After successful sign in, Navigate to chrome://settings page, Click on 'Avtar' and then Click on 'Enter passphrase' button. 3.Observe. Actual: Focus Ring appears bigger in size than expected around the passphrase textbox and submit button. Expected: Focus ring should cover only passphrase textbox. This is regression issue broken in ‘M-69’ and below is the hasbisect per-revision info: Good Build: 69.0.3469.3 (Revision:569383) Bad Build: 69.0.3472.0 (Revision:569948) You are probably looking for a change made after 569449 (known good), but no later than 569450 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fe58d1a30355efe4ee7247a639f72ee724b65a53..944030dfcb0698b072b052bd03ebc3f8ef7d4b7d Suspecting: https://chromium.googlesource.com/chromium/src/+/944030dfcb0698b072b052bd03ebc3f8ef7d4b7d scottchen@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jun 25 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/31e592b5823badfedeeb824ab6521615e5f78329 commit 31e592b5823badfedeeb824ab6521615e5f78329 Author: Scott Chen <scottchen@chromium.org> Date: Mon Jun 25 22:16:46 2018 WebUI[MD-refresh]: fix various tabindex issues for cr-input This fixes a few bugs introduced by 1103002 to cr-input, as well as making cr-input more robust against edge-cases: likely cases: - |tabindex| initially set by element are mistakenly set to 0. - if element has both |tabindex| and |disabled| set, element would not know what to set |tabindex| to once |disabled| is removed. - clicking on a |disabled| cr-input would set its |tabindex| to 0 again. edge case: - if |disabled| is changed to true in the same cycle as pointerdown is fired, then |tabindex| state gets messed up. Bug: 832177 , 856118 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I91161ecde90e816340aa38db4646b3f8eedd7a8b Reviewed-on: https://chromium-review.googlesource.com/1111201 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#570198} [modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/chrome/browser/resources/settings/people_page/sync_page.js [modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/chrome/test/data/webui/cr_elements/cr_input_test.js [modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/ui/webui/resources/cr_elements/cr_input/cr_input.js [modify] https://crrev.com/31e592b5823badfedeeb824ab6521615e5f78329/ui/webui/resources/cr_elements/cr_input/cr_input_style_css.html
,
Jun 25 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpa...@chromium.org
, Jun 25 2018