TtsAccessibilityTest.MANAGE_TTS_SETTINGS_aria_valid_attr_value flaky on CrOS |
||||||
Issue descriptionTtsAccessibilityTest.MANAGE_TTS_SETTINGS_aria_valid_attr_value is flaky on chromium.chromiumos builder: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TtsAccessibilityTest.MANAGE_TTS_SETTINGS_aria_valid_attr_value Assigning to dpapad@ to investigate.
,
Jun 25 2018
Assigning to Katie. Looking at the log [1] This looks like a legitimate a11y failure [2], we're using percentages in aria-validmin and aria-valuemax but the a11y audit expects numbers [3]. We might need to just drop the percent. [1] https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8942730170459874096%2F%2B%2Fsteps%2Fmash_browser_tests%2F0%2Flogs%2FTtsAccessibilityTest.MANAGE_TTS_SETTINGS_aria_valid_attr_value%2F0 [2] https://dequeuniversity.com/rules/axe/3.0/aria-valid-attr-value?application=axeAPI [3] https://www.w3.org/TR/wai-aria/#aria-valuemin
,
Jun 25 2018
,
Jun 25 2018
Looks like we shouldn't set aria-valuemax and aria-valuemin from the tick label (https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device_page/display_size_slider.js?type=cs&l=487), because the label is a string.
,
Jun 25 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c07c41eadf11246f1325079cef1d2c5c6903b24 commit 5c07c41eadf11246f1325079cef1d2c5c6903b24 Author: Katie D <katie@chromium.org> Date: Mon Jun 25 23:47:54 2018 Fix flaky aria attr test on TTS subpage. This makes sure the aria-valuemax, aria-valuemin, and aria-valuenow are numbers rather than strings. Bug: 856051 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: If75cd1af2ec4bc5928655daa7337fd4a52479fec Reviewed-on: https://chromium-review.googlesource.com/1114134 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#570241} [modify] https://crrev.com/5c07c41eadf11246f1325079cef1d2c5c6903b24/chrome/browser/resources/settings/a11y_page/BUILD.gn [modify] https://crrev.com/5c07c41eadf11246f1325079cef1d2c5c6903b24/chrome/browser/resources/settings/a11y_page/tts_subpage.js [modify] https://crrev.com/5c07c41eadf11246f1325079cef1d2c5c6903b24/chrome/browser/resources/settings/device_page/display.js [modify] https://crrev.com/5c07c41eadf11246f1325079cef1d2c5c6903b24/chrome/browser/resources/settings/device_page/display_size_slider.js
,
Jun 25 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dpa...@chromium.org
, Jun 25 2018Labels: OS-Chrome
Owner: ----
Status: Available (was: Assigned)