New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856039 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Keyboard accessory doesn't persist when Chrome is sent to the background

Project Member Reported by fhorschig@chromium.org, Jun 25 2018

Issue description

Switching back and forth between apps via Recents
→ KA vanishes for good


 
Blocking: 853794
(This improved a little bit: it only vanishes for the current tab. Opening a new one brings it back - no cold start required)
Cc: ioanap@chromium.org fhorschig@chromium.org
 Issue 856138  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75644b6915c0d14913feec14b82e48bbab70bcdd

commit 75644b6915c0d14913feec14b82e48bbab70bcdd
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Wed Aug 08 12:30:39 2018

[Android] Restore keyboard accessory on resume of Chrome

When Chrome is backgrounded (e.g. by pressing home or locking the
device), its state is properly preserved but wasn't restored before this
CL.

With this CL, this is done now. This fixes issues like the keyboard
accessory being permanently dismissed or keeping a state that should
have been reset (most notably the generation button).

Bug:  856039 ,  870238 
Change-Id: I5543fb5b7dc8cfbe690d7df9a6ddb47346928704
Reviewed-on: https://chromium-review.googlesource.com/1160481
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581529}
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/75644b6915c0d14913feec14b82e48bbab70bcdd/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java

Status: Fixed (was: Started)

Sign in to add a comment