New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 856033 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794



Sign in to add a comment

Opening Tab Switcher while KA is open

Project Member Reported by fhorschig@chromium.org, Jun 25 2018

Issue description

What steps will reproduce the problem?
(1) Select a form field
(2) Open a bottom sheet
(3) Trigger the tab switcher

What is the expected result?
Bottom sheet is dismissed.

What happens instead?
Bottom sheet still visible
 
Blocking: 853794
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a90315cca8eed768114ec8203989f756acdb02

commit 37a90315cca8eed768114ec8203989f756acdb02
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jun 29 15:15:32 2018

[Android, Crash] Hide accessory sheet during tab overview

This CL makes the ManualFillingMediator consider various cases of a tab
being hidden. Most importantly, it's now aware to when the tab overview
is opened which resolves a crash that happened in combination with the
HorizontalTabSwitcherAndroid feature.

Bug: 856523,  853742 ,  856033 
Change-Id: If09a3ac3551e2ebed1cfac6bb4870ff98d6c1ec1
Reviewed-on: https://chromium-review.googlesource.com/1118384
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571480}
[modify] https://crrev.com/37a90315cca8eed768114ec8203989f756acdb02/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/37a90315cca8eed768114ec8203989f756acdb02/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/37a90315cca8eed768114ec8203989f756acdb02/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/37a90315cca8eed768114ec8203989f756acdb02/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
[modify] https://crrev.com/37a90315cca8eed768114ec8203989f756acdb02/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java

Status: Fixed (was: Available)

Sign in to add a comment