Android memory improvements around 568608:568730 |
||||
Issue descriptionWant to figure out what caused the improvements seen e.g. here: https://chromeperf.appspot.com/report?sid=beab815ce885290ed5433f9be17935d54f44095ec32a1a36d9dbf9c2b632fff0&start_rev=1528773394&end_rev=1529899490
,
Jun 25 2018
,
Jun 26 2018
=== BISECT JOB RESULTS === Bisect was unable to run to completion Error: INFRA_FAILURE The bisect was able to narrow the range, you can try running with: good_revision: 0ee7fda8a31cf50d9c839fd4552aaea9d0e86ab9 bad_revision : f4861bab676ac20d78498f841c34e462efb043bf If failures persist contact the team (see below) and report the error. Bisect Details Configuration: go-phone-1024-perf-bisect Benchmark : memory.top_10_mobile Metric : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/foreground/http_en_m_wikipedia_org_wiki_Science Change : 1.28% | 33071010.6667 -> 32649244.5714 Revision Result N android-chrome@bfbc254ab1 33071011 +- 317550 21 good android-chrome@bfbc254ab1,chromium@568638 33258232 +- 244668 6 good android-chrome@bfbc254ab1,chromium@568653 33145373 +- 256792 14 good android-chrome@bfbc254ab1,chromium@568655 32515320 +- 266498 6 bad android-chrome@bfbc254ab1,chromium@568657 32813304 +- 306182 21 bad android-chrome@bfbc254ab1,chromium@568661 32746744 +- 278582 14 bad android-chrome@bfbc254ab1,chromium@568671 32776645 +- 249223 20 bad android-chrome@3447e60a36 32649245 +- 363102 14 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.en.m.wikipedia.org.wiki.Science memory.top_10_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8942760892559386752 For feedback, file a bug with component Speed>Bisection
,
Jun 26 2018
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14ff998f240000
,
Jun 26 2018
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14ff998f240000 [embedded-builtins] Enable on all arches except x86 for benchmarks by sigurds@chromium.org https://chromium.googlesource.com/v8/v8/+/f5a8352b0fbba0d88104de7949a0d0c238765cf8 2.856e+07 → 2.803e+07 (-5.374e+05) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jun 28 2018
Awesome! Just confirmed that your change caused significant memory improvements across all Android configs. Nothing else for you to do here. :)
,
Jun 28 2018
Great, thanks!
,
Jul 13
,
Jul 17
Issue 862979 has been merged into this issue. |
||||
►
Sign in to add a comment |
||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jun 25 2018