New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 856026 link

Starred by 1 user
Status: Verified
Owner:
fhorschig@chromium.org
Closed: Jul 26
Cc:
█ nepper@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 853794
issue 867871



Sign in to add a comment

Switching from one field to the next while Keyboard Accessory is open

Project Member Reported by fhorschig@chromium.org, Jun 25 2018 
1. Select a form field
2. Open the passwords accessory sheet
3. Select a different field

Expected Result:
The keyboard accessory should be hidden when the focus changes.

Observed result:
The sheet stays open and the keyboard opens in addition.

Comment 1 by fhorschig@chromium.org, Jun 25 2018

Blocking: 853794

Comment 2 by fhorschig@chromium.org, Jul 5

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d204163481b39608bb438f612f954dba21ac9f

commit e3d204163481b39608bb438f612f954dba21ac9f
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Jul 19 11:01:22 2018

[Android] Close accessory when suggestions were filled

This CL causes the accessory sheet to close when a user selected a valid
filling suggestions.
There is no indicator of the negative case yet (i.e. error during
filling).

TBR=rouslan@chromium.org
TBR Reason: The test has been flaky for a while and also doesn't make
much sense. Like all the others, I am disabling it. The feature it tests
isn't even activated yet.

Bug:  856026 , 857592
Change-Id: I8ccdbe2b06c49215b0799fd435823e584dfe4f11
Reviewed-on: https://chromium-review.googlesource.com/1126244
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576436}
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/browser/android/password_manager/password_accessory_view_android.cc
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/browser/android/password_manager/password_accessory_view_android.h
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/e3d204163481b39608bb438f612f954dba21ac9f/chrome/browser/password_manager/password_accessory_view_interface.h

Comment 4 by fhorschig@chromium.org, Jul 19

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ec520748ca890e1c81ba39c61622be1f0d491fb

commit 6ec520748ca890e1c81ba39c61622be1f0d491fb
Author: Brian Sheedy <bsheedy@chromium.org>
Date: Thu Jul 19 23:43:45 2018

Revert "[Android] Close accessory when suggestions were filled"

This reverts commit e3d204163481b39608bb438f612f954dba21ac9f.

Reason for revert: Cause of  https://crbug.com/865749 

Original change's description:
> [Android] Close accessory when suggestions were filled
> 
> This CL causes the accessory sheet to close when a user selected a valid
> filling suggestions.
> There is no indicator of the negative case yet (i.e. error during
> filling).
> 
> TBR=rouslan@chromium.org
> TBR Reason: The test has been flaky for a while and also doesn't make
> much sense. Like all the others, I am disabling it. The feature it tests
> isn't even activated yet.
> 
> Bug:  856026 , 857592
> Change-Id: I8ccdbe2b06c49215b0799fd435823e584dfe4f11
> Reviewed-on: https://chromium-review.googlesource.com/1126244
> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#576436}

TBR=rouslan@chromium.org,vasilii@chromium.org,fhorschig@chromium.org

Change-Id: If43f923c0ceb28bc63bea99e7e7945c51bb9f689
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  856026 , 857592
Reviewed-on: https://chromium-review.googlesource.com/1144065
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576695}
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/browser/android/password_manager/password_accessory_view_android.cc
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/browser/android/password_manager/password_accessory_view_android.h
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/6ec520748ca890e1c81ba39c61622be1f0d491fb/chrome/browser/password_manager/password_accessory_view_interface.h

Comment 6 by fhorschig@chromium.org, Jul 24

Status: Started (was: Fixed)

Comment 7 by fhorschig@chromium.org, Jul 26

Blocking: 867871
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a

commit f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Jul 26 17:01:22 2018

[Android] Close accessory when suggestions were filled

This is a reland of https://chromium-review.googlesource.com/1126244
which was reverted because it promoted a legacy bug which triggered
a 2D keyboard in VR mode.

The keyboard accessory is not enabled in VR mode.
There is a test to ensure that resetting that the sheet doesn't
trigger the keyboard unnecessarily anymore.

Original change's description:
> This CL causes the accessory sheet to close when a user selected a valid
> filling suggestions.
> There is no indicator of the negative case yet (i.e. error during
> filling).

TBR=rouslan@chromium.org

Bug:  856026 , 857592,  865749 
Change-Id: I71abca9366cfa96789ffe7538204f5435332e4ac
Reviewed-on: https://chromium-review.googlesource.com/1146361
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578343}
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModel.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/android/password_manager/password_accessory_view_android.cc
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/android/password_manager/password_accessory_view_android.h
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a/chrome/browser/password_manager/password_accessory_view_interface.h

Comment 9 by fhorschig@chromium.org, Jul 26

Status: Fixed (was: Started)

Comment 10 by fhorschig@chromium.org, Jul 31

Labels: Merge-Request-69
Merge request rationale:
This increases the UI stability and prevents a 2D keyboard in VR mode (see  issue 865749 ).
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 31

Labels: -Merge-Request-69 Merge-Review-69 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by benmason@chromium.org, Aug 2

Labels: -Merge-Review-69 Merge-Approved-69
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 2

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2c85815f804966792a33e00f5e9ff0fb59ce333

commit f2c85815f804966792a33e00f5e9ff0fb59ce333
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Aug 02 17:11:01 2018

[Android] Close accessory when suggestions were filled

This is a reland of https://chromium-review.googlesource.com/1126244
which was reverted because it promoted a legacy bug which triggered
a 2D keyboard in VR mode.

The keyboard accessory is not enabled in VR mode.
There is a test to ensure that resetting that the sheet doesn't
trigger the keyboard unnecessarily anymore.

Original change's description:
> This CL causes the accessory sheet to close when a user selected a valid
> filling suggestions.
> There is no indicator of the negative case yet (i.e. error during
> filling).

TBR=rouslan@chromium.org

Bug:  856026 , 857592,  865749 
Change-Id: I71abca9366cfa96789ffe7538204f5435332e4ac
Reviewed-on: https://chromium-review.googlesource.com/1146361
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#578343}(cherry picked from commit f12d4ba6e1e497efa70fbb8d6a76fd36dadf553a)
Reviewed-on: https://chromium-review.googlesource.com/1160981
Cr-Commit-Position: refs/branch-heads/3497@{#340}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModel.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/android/password_manager/password_accessory_view_android.cc
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/android/password_manager/password_accessory_view_android.h
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/password_manager/password_accessory_controller.cc
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/password_manager/password_accessory_controller.h
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/password_manager/password_accessory_controller_unittest.cc
[modify] https://crrev.com/f2c85815f804966792a33e00f5e9ff0fb59ce333/chrome/browser/password_manager/password_accessory_view_interface.h

Comment 14 by aska...@chromium.org, Aug 2

Status: Verified (was: Fixed)
Verified that the keyboard accessory closes when switched from one field to another. 70.0.3510.0.
►

Sign in to add a comment