New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 15
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 1
Type: Bug
Flaky-Test: TouchActionBrowserTest.DefaultAuto



Sign in to add a comment

TouchActionBrowserTest.DefaultAuto is Flaky

Project Member Reported by Findit, Jun 25

Issue description

Status: Assigned (was: Available)
Hi Xida, FindIt suspects that your patch to deflake may have introduced new flake. Could you please take a look?

The flake seems pretty bad on the *san bots [1], so I'm going to revert the patch.

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_content_browsertests&tests=TouchActionBrowserTest.DefaultAuto
Owner: xidac...@chromium.org
Components: Blink>Input
Labels: -Sheriff-Chromium OS-Chrome OS-Linux
The msan flakes should go away with https://chromium-review.googlesource.com/c/chromium/src/+/1116788.

Of interest:

https://chromium-swarm.appspot.com/task?id=3e538c5bff5b4a10&refresh=10&show_raw=1

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=TouchActionBrowserTest.DefaultAuto

I'm curious to know if the test becomes non-flaky after the fix above lands.

Removing from sheriff queue for now. Feel free to mark the bug as fixed if the flakes seem to be resolved.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/249f3a8feb51c567f950e4a34c608bae7561f629

commit 249f3a8feb51c567f950e4a34c608bae7561f629
Author: Greg Thompson <grt@chromium.org>
Date: Wed Jun 27 13:58:44 2018

Fix uninitialized member in TouchEvent.

One ctor was leaving the hovering_ member in a non-deterministic state.

BUG= 855979 
TBR=nzolghadr@chromium.org

Change-Id: I4b49426d08940cd24bb31039bfa5a75b14aadb6d
Reviewed-on: https://chromium-review.googlesource.com/1116788
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570751}
[modify] https://crrev.com/249f3a8feb51c567f950e4a34c608bae7561f629/ui/events/event.h

I think the test may still be flaky for other reasons: https://chromium-swarm.appspot.com/task?id=3e6289d1f2b06910&refresh=10&show_raw=1
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd9869d20cd802e82013e812424c9b32835d4a86

commit bd9869d20cd802e82013e812424c9b32835d4a86
Author: Xida Chen <xidachen@chromium.org>
Date: Wed Jul 11 18:59:42 2018

[Code health] Enable all TouchActionBrowserTests but not on Debug

After we landed this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1124699
which deflakes one of the TouchActionBrowserTests, the flakiness
dashboard shows that all other tests are stable except on Debug bots.
So this CL enables all the tests and disable them on Debug builds.

TBR=tdresser@chromium.org

Bug:  855979 ,  833015 
Change-Id: Ie9aff86f735bb6dbe2923f080cbe09f59ee4e1b1
Reviewed-on: https://chromium-review.googlesource.com/1129099
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574271}
[modify] https://crrev.com/bd9869d20cd802e82013e812424c9b32835d4a86/content/browser/renderer_host/input/touch_action_browsertest.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da109c8fd1b66a54c514b3012c29ebb232c113e9

commit da109c8fd1b66a54c514b3012c29ebb232c113e9
Author: Xida Chen <xidachen@chromium.org>
Date: Thu Jul 12 16:02:09 2018

[Code health] Disable TouchActionBrowserTests on Debug and *San bots

These tests are flaky on Debug builds and *San bots. These tests sends
synthetic gesture event and measure scroll offset. It should be fine
without coverages on Debug and *San builds.

TBR=sahel@chromium.org, tdresser@chromium.org

Bug:  855979 ,  833015 
Change-Id: I009d3557454e0aab960d35fc5256ed487c2e47fe
Reviewed-on: https://chromium-review.googlesource.com/1135195
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574579}
[modify] https://crrev.com/da109c8fd1b66a54c514b3012c29ebb232c113e9/content/browser/renderer_host/input/touch_action_browsertest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment