New issue
Advanced search Search tips

Issue 855950 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Integer-overflow in blink::IntPoint::Move

Project Member Reported by ClusterFuzz, Jun 25 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5321902722383872

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntPoint::Move
  blink::WebPluginContainerImpl::FrameRect
  blink::WebPluginContainerImpl::ComputeClipRectsForPlugin
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5321902722383872

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 25 2018

Components: Blink Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 2 by kojii@chromium.org, Jun 25 2018

Components: -Blink -Platform Blink>Scroll
Owner: szager@chromium.org
Status: Assigned (was: Untriaged)
Probably this one?
https://chromium-review.googlesource.com/c/chromium/src/+/923427
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72599b86937978b14b7992e25c0462373d0c5515

commit 72599b86937978b14b7992e25c0462373d0c5515
Author: Stefan Zager <szager@chromium.org>
Date: Mon Jun 25 21:08:25 2018

Don't overflow EmbeddedContentView frame rect.

This extends to the other EmbeddedContentView subclasses the same fix
as was made to LocalFrameView in:

https://chromium-review.googlesource.com/1055675

BUG= 855950 
R=skobes@chromium.org

Change-Id: I4c9f29fc1e04213ff22e5debd9630ebb81eb1812
Reviewed-on: https://chromium-review.googlesource.com/1114071
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570180}
[modify] https://crrev.com/72599b86937978b14b7992e25c0462373d0c5515/third_party/blink/renderer/core/exported/web_plugin_container_impl.cc
[modify] https://crrev.com/72599b86937978b14b7992e25c0462373d0c5515/third_party/blink/renderer/core/frame/remote_frame_view.cc

Project Member

Comment 4 by ClusterFuzz, Jun 26 2018

ClusterFuzz has detected this issue as fixed in range 570179:570182.

Detailed report: https://clusterfuzz.com/testcase?key=5321902722383872

Fuzzer: ifratric-browserfuzzer-v3
Job Type: linux_ubsan_chrome
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  blink::IntPoint::Move
  blink::WebPluginContainerImpl::FrameRect
  blink::WebPluginContainerImpl::ComputeClipRectsForPlugin
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=549059:549062
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_chrome&range=570179:570182

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5321902722383872

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Jun 26 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5321902722383872 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment