New issue
Advanced search Search tips

Issue 855917 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: height >= 0 in layout_box.cc

Project Member Reported by ClusterFuzz, Jun 24 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5762306924085248

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  height >= 0 in layout_box.cc
  blink::LayoutBox::SetOverrideLogicalHeight
  blink::LayoutTableCell::SetOverrideLogicalHeightFromRowHeight
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=553542:553546

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5762306924085248

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 24 2018

Components: Blink>Layout
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 24 2018

Labels: Test-Predator-Auto-Owner
Owner: r...@igalia.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/3594da711b52b5eac14253f3e2a78f55a9fcb608 (Fixing LayoutBox overrides so they store what they say).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.

Comment 3 by r...@igalia.com, Jun 25 2018

Cc: svil...@igalia.com jfernan...@igalia.com
I can reproduce it, uploading a reduced test case.
bug-855917.html
163 bytes View Download
Cc: r...@igalia.com
Owner: dgro...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5f185d1c5985029f448f1f90dc633eb43196116

commit a5f185d1c5985029f448f1f90dc633eb43196116
Author: David Grogan <dgrogan@chromium.org>
Date: Fri Jun 29 21:24:28 2018

[css-tables] Stop row collapsing from subtracting border spacing twice

A collapsed row would subtract border-spacing right away, then also
subtract it later when passing heights to %-height children.

Bug:  855917 
Change-Id: I29f5e01035b7f9dc76af337fbd65cc332d50376c
Reviewed-on: https://chromium-review.googlesource.com/1116249
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571636}
[modify] https://crrev.com/a5f185d1c5985029f448f1f90dc633eb43196116/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/a5f185d1c5985029f448f1f90dc633eb43196116/third_party/blink/renderer/core/layout/layout_table_section.cc
[modify] https://crrev.com/a5f185d1c5985029f448f1f90dc633eb43196116/third_party/blink/renderer/core/layout/layout_table_section_test.cc

Status: Fixed (was: Started)
Project Member

Comment 7 by ClusterFuzz, Jun 30 2018

ClusterFuzz has detected this issue as fixed in range 571635:571636.

Detailed report: https://clusterfuzz.com/testcase?key=5762306924085248

Fuzzer: bj_broddelwerk
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  height >= 0 in layout_box.cc
  blink::LayoutBox::SetOverrideLogicalHeight
  blink::LayoutTableCell::SetOverrideLogicalHeightFromRowHeight
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=553542:553546
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=571635:571636

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5762306924085248

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jun 30 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5762306924085248 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment