New issue
Advanced search Search tips

Issue 855894 link

Starred by 4 users

Issue metadata

Status: Assigned
Owner:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 844766
issue 855893



Sign in to add a comment

Ship mojo_core on Windows

Project Member Reported by roc...@chromium.org, Jun 24 2018

Issue description

It will be needed to support Chrome Cleaner at the very least, but there will almost certainly be other use cases.
 

Comment 1 by roc...@chromium.org, Jun 24 2018

Doc (google.com only) here: https://docs.google.com/document/d/1-Xn2kx9_P0Giu5gwyWyo4eluxqc3E5lqdE-3BrP1pdU/edit#heading=h.efawfigoq9be

It's focused on Chrome OS but the gist is the same: ship a DLL with the Chrome binary, and teach //mojo/public libraries how to find and use it in applications that don't link and call directly into //mojo/edk.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db79c73c3f55e7907fb6048846455814170736b7

commit db79c73c3f55e7907fb6048846455814170736b7
Author: Ken Rockot <rockot@chromium.org>
Date: Wed Jun 27 00:57:38 2018

Build mojo_core library for Windows

Enables mojo_core to build as a data dependency of the Chrome binary on
Windows, as it already does for Chrome OS builds.

Also adds the ability for applications to point to a specific mojo_core
DLL path before falling back onto the MOJO_CORE_LIBRARY_PATH environment
variable.

This only causes the DLL to build as a side effect of normal Chrome
builds, and enables the corresponding mojo_core_unittests suite to be
run on Windows bots. The DLL is not yet included in any Chrome installer
builds.

Bug: 855894
Change-Id: Iecb19e0efda73b485269cf23fb0f2ceb6891fcb9
Reviewed-on: https://chromium-review.googlesource.com/1112923
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570603}
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/chrome/BUILD.gn
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/mojo/edk/BUILD.gn
[add] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/mojo/edk/mojo_core.def
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/mojo/edk/system/system_impl_export.h
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/mojo/public/c/system/thunks.cc
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/mojo/public/c/system/types.h
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/testing/buildbot/chromium.win.json
[modify] https://crrev.com/db79c73c3f55e7907fb6048846455814170736b7/testing/buildbot/test_suites.pyl

Comment 3 by roc...@chromium.org, Jun 27 2018

Blocking: 844766
Owner: rockot@google.com

Sign in to add a comment