New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855885 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 23 2018

Issue description

"telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 8 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkx0ZWxlbWV0cnkuaW50ZXJuYWwuYWN0aW9ucy5wbGF5X3VuaXR0ZXN0LlBsYXlBY3Rpb25UZXN0LnRlc3RQbGF5V2FpdEZvckVuZGVkDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 853865 .
 

Comment 1 by shend@chromium.org, Jun 25 2018

Cc: nednguyen@chromium.org
Owner: perezju@chromium.org
Status: Assigned (was: Untriaged)
Now flaking on mac_chromium_rel_ng.

perezju@, could you please take at look at this? Thanks. Tests were already disabled on Mac 10.10 in  https://crbug.com/853865 .
Cc: -nednguyen@chromium.org perezju@chromium.org
Owner: nednguyen@chromium.org
According to [1] mac_chromium_rel_ng is running Mac-10.13.

Ned, what should we disable on? Both 10.10 and 10.13? Just 10.13? All of mac?

[1]: https://chromium-swarm.appspot.com/task?id=3e4e7e94a83d0b10&refresh=10&show_raw=1
Let's disable all mac for now
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Jun 25 2018

Detected 3 new flakes for test/step "telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkx0ZWxlbWV0cnkuaW50ZXJuYWwuYWN0aW9ucy5wbGF5X3VuaXR0ZXN0LlBsYXlBY3Rpb25UZXN0LnRlc3RQbGF5V2FpdEZvckVuZGVkDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/29f3b8927f88c9c7e6412e5cfa12646f78d92f00

commit 29f3b8927f88c9c7e6412e5cfa12646f78d92f00
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jun 25 10:49:18 2018

[Telemetry] Disable flaky tests on mac

Disabling all of the following:
- telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWait
- telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWaitForElement
- telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded

Due to flakiness on mac_chromium_rel_ng

TBR=nednguyen@google.com
Bug: chromium:855885
Change-Id: I5afa106649253db3166e70e64a7b504ac21fdd8c
Reviewed-on: https://chromium-review.googlesource.com/1113311
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/29f3b8927f88c9c7e6412e5cfa12646f78d92f00/telemetry/telemetry/internal/actions/action_runner_unittest.py
[modify] https://crrev.com/29f3b8927f88c9c7e6412e5cfa12646f78d92f00/telemetry/telemetry/internal/actions/play_unittest.py

Project Member

Comment 6 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b001fc2b94c152a655818dec48c51484a5365de3

commit b001fc2b94c152a655818dec48c51484a5365de3
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jun 25 11:56:53 2018

Roll src/third_party/catapult 2e625dcb82db..29f3b8927f88 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/2e625dcb82db..29f3b8927f88


git log 2e625dcb82db..29f3b8927f88 --date=short --no-merges --format='%ad %ae %s'
2018-06-25 perezju@chromium.org [Telemetry] Disable flaky tests on mac


Created with:
  gclient setdep -r src/third_party/catapult@29f3b8927f88

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855885
TBR=sullivan@chromium.org

Change-Id: Iff8453806d324ba6628a40cb5050712d7bfaabcd
Reviewed-on: https://chromium-review.googlesource.com/1113060
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570012}
[modify] https://crrev.com/b001fc2b94c152a655818dec48c51484a5365de3/DEPS

Labels: -Sheriff-Chromium

Comment 8 by olka@chromium.org, Jun 28 2018

Labels: Test-Disabled

Comment 9 by yigu@chromium.org, Jun 28 2018

Cc: rhalavati@chromium.org
 Issue 855362  has been merged into this issue.

Sign in to add a comment