New issue
Advanced search Search tips

Issue 855883 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Flaky PictureInPictureWindowControllerBrowserTest.MultipleBrowserWindowOnePIPWindow on viz_browsertests

Project Member Reported by mlamouri@chromium.org, Jun 23 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd71cac9e34e91f0c184e556b18e1e201d4b2a7c

commit cd71cac9e34e91f0c184e556b18e1e201d4b2a7c
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Sat Jun 23 22:40:43 2018

Picture-in-Picture: disable flaky PictureInPictureWindowControllerBrowserTest.

Bug:  855883 
Change-Id: I383e660319c86bf64872d2183cb36998cabbffe8
TBR: mlamouri@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1112945
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569898}
[modify] https://crrev.com/cd71cac9e34e91f0c184e556b18e1e201d4b2a7c/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Labels: -OS-Windows -OS-Mac
Summary: Flaky PictureInPictureWindowControllerBrowserTest.MultipleBrowserWindowOnePIPWindow on viz_browsertests (was: Flaky PictureInPictureWindowControllerBrowserTest.MultipleBrowserWindowOnePIPWindow on viz_browsertests ChromeOS)
Seems to also apply on Linux.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9942d2112e8631dc43d3e6f3531b2fca9d5bbcfa

commit 9942d2112e8631dc43d3e6f3531b2fca9d5bbcfa
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Jun 25 16:53:04 2018

Disable flaky MultipleBrowserWindowOnePIPWindow on Linux too

Bug:  855883 
Change-Id: I208dab13ef989714b5385b92a70fb70155bddf3c
TBR: mlamouri@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1113897
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570068}
[modify] https://crrev.com/9942d2112e8631dc43d3e6f3531b2fca9d5bbcfa/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fe1784a5f87ee8c82fafee88c18c3d3bc0dcde3

commit 7fe1784a5f87ee8c82fafee88c18c3d3bc0dcde3
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Jul 10 03:06:51 2018

Picture-in-Picture: re-enable flaky browsertests.

All the flaky tests were because of a DCHECK that is no longer relevant.

Bug:  855883 ,  860513 
Change-Id: I71de5bf9506e76959e3da4507b91a1e34672f7f4
Reviewed-on: https://chromium-review.googlesource.com/1130850
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573601}
[modify] https://crrev.com/7fe1784a5f87ee8c82fafee88c18c3d3bc0dcde3/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment