Failed due to invalid state transition:

[ RUN      ] TabManagerTest.TabPendingFreezeAndUnfreeze
[50769:4355:0622/222017.427608:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
[50774:775:0622/222017.506658:WARNING:vt_video_decode_accelerator_mac.cc(193)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "codecOpenErr" (-8973)
[50774:775:0622/222017.507001:WARNING:vt_video_decode_accelerator_mac.cc(215)] Hardware decoding with VideoToolbox is not supported
2018-06-22 22:20:17.512 browser_tests[50769:704566] *** Owner supplied to -[NSTrackingArea initWithRect:options:owner:userInfo:] referenced a deallocating object. Tracking area behavior is undefined. Break on NSTrackingAreaDeallocatingOwnerError to debug.
[50774:775:0622/222017.633762:ERROR:vt_video_encode_accelerator_mac.cc(516)]  VTCompressionSessionCreate failed: -12908
[50769:775:0622/222017.764643:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11
[50769:775:0622/222018.770030:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -102
[50769:89859:0622/222018.773316:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[50769:775:0622/222018.779137:FATAL:tab_lifecycle_unit.cc(732)] Check failed: IsValidStateChange(last_state, GetState(), reason). Cannot transition TabLifecycleUnit state from LifecycleUnitState::ACTIVE to LifecycleUnitState::FROZEN with reason LifecycleUnitStateChangeReason::RENDERER_INITIATED

Hi fdoray@, could you please take a look? Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc4fa88cbe0c085a547da3cba7525596eaeb619a

commit cc4fa88cbe0c085a547da3cba7525596eaeb619a
Author: Darren Shen <shend@chromium.org>
Date: Mon Jun 25 03:51:38 2018

Disable TabManagerTest.TabPendingFreezeAndUnfreeze

Flaky on linux and mac.

TBR=fdoray@chromium.org

Bug:  855874 
Change-Id: If2699ad034204225497ed2d9e01f5082a3e0dd17
Reviewed-on: https://chromium-review.googlesource.com/1112895
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569957}
[modify] https://crrev.com/cc4fa88cbe0c085a547da3cba7525596eaeb619a/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Detected 3 new flakes for test/step "TabManagerTest.TabPendingFreezeAndUnfreeze". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipUYWJNYW5hZ2VyVGVzdC5UYWJQZW5kaW5nRnJlZXplQW5kVW5mcmVlemUM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

I don't think the suppression above worked. Here's a recent tryjob where it still failed on two consecutive tryjobs:

https://chromium-review.googlesource.com/c/chromium/src/+/1114356

Urgh, my bad. I disabled TabFreezeAndUnfreeze, not TabPendingFreezeAndUnfreeze. Fixing this now. Thanks for the catch.

CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1114414
but the Win build bots are broken (https://crbug.com/856512), so I can't land it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f0db23e38268d29d3ec6ac6f40c5e2c5b3ff866

commit 5f0db23e38268d29d3ec6ac6f40c5e2c5b3ff866
Author: Darren Shen <shend@chromium.org>
Date: Tue Jun 26 17:39:15 2018

Disable TabManagerTest.TabPendingFreezeAndUnfreeze.

Disable TabManagerTest.TabPendingFreezeAndUnfreeze
TabManagerTest.TabFreezeAndUnfreeze was incorrectly disabled.

TBR=fdoray@chromium.org

Bug:  855874 
Change-Id: If525e002423677ce9547a404d7bb44d22b5dcdbe
Reviewed-on: https://chromium-review.googlesource.com/1114414
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570452}
[modify] https://crrev.com/5f0db23e38268d29d3ec6ac6f40c5e2c5b3ff866/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

Detected 7 new flakes for test/step "TabManagerTest.TabPendingFreezeAndUnfreeze". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNQsSBUZsYWtlIipUYWJNYW5hZ2VyVGVzdC5UYWJQZW5kaW5nRnJlZXplQW5kVW5mcmVlemUM. This message was posted automatically by the chromium-try-flakes app.

Flaking on Linux, too:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TabManagerTest.TabPendingFreezeAndUnfreeze

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf67f62de13f1646fe38af70e230c558272a411f

commit bf67f62de13f1646fe38af70e230c558272a411f
Author: Greg Thompson <grt@chromium.org>
Date: Wed Jun 27 12:01:53 2018

Disable TabManagerTest.TabPendingFreezeAndUnfreeze on Linux, too.

BUG= 855874 
TBR=fdoray@chromium.org
NOTRY=true

Change-Id: I882e8d1a848e0f7d86ddbac4bc47b92715d94da0
Reviewed-on: https://chromium-review.googlesource.com/1116791
Commit-Queue: Greg Thompson <grt@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570735}
[modify] https://crrev.com/bf67f62de13f1646fe38af70e230c558272a411f/chrome/browser/resource_coordinator/tab_manager_browsertest.cc

 Issue 854777  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5dccf31076369b7cef45aa8dd948cf2b182e32e8

commit 5dccf31076369b7cef45aa8dd948cf2b182e32e8
Author: Francois Doray <fdoray@chromium.org>
Date: Tue Jul 10 20:26:40 2018

RC: Add LifecycleUnitState::PENDING_UNFREEZE.

A LifeycleUnit transitions to that state after a call to Unfreeze().
It stays in that state until the unfreeze actually happens.

Having this intermediate state instead of transitionning directly
to ACTIVE is important to be able to track when the renderer never
notifies the browser that it ran the "onresume" callback.

Bug: 775644,  855874 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Icf578cd12d113e569b017b604e4e835beeb331bf
Reviewed-on: https://chromium-review.googlesource.com/1131845
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573885}
[modify] https://crrev.com/5dccf31076369b7cef45aa8dd948cf2b182e32e8/chrome/browser/resource_coordinator/lifecycle_unit_state.mojom
[modify] https://crrev.com/5dccf31076369b7cef45aa8dd948cf2b182e32e8/chrome/browser/resource_coordinator/tab_lifecycle_unit.cc
[modify] https://crrev.com/5dccf31076369b7cef45aa8dd948cf2b182e32e8/chrome/browser/resource_coordinator/tab_manager_browsertest.cc
[modify] https://crrev.com/5dccf31076369b7cef45aa8dd948cf2b182e32e8/chrome/browser/resources/discards/discards.js