"ProfileChooserViewExtensionsTest.SigninButtonHasFocus" is flaky |
||||||
Issue description"ProfileChooserViewExtensionsTest.SigninButtonHasFocus" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVQcm9maWxlQ2hvb3NlclZpZXdFeHRlbnNpb25zVGVzdC5TaWduaW5CdXR0b25IYXNGb2N1cww. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 25 2018
Failing here: [ RUN ] ProfileChooserViewExtensionsTest.SigninButtonHasFocus [4848:5560:0624/030439.883:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062 [4848:4476:0624/030439.899:WARNING:chrome_browser_main_win.cc(653)] Command line too long for RegisterApplicationRestart: --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=ProfileChooserViewExtensionsTest.SigninButtonHasFocus --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4000_23690\results4000_12406\test_results.xml" --test-launcher-summary-output="e:\b\s\w\iojkwr07\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4000_23690\d4000_8615" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,SpeculativePreconnect,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank [2476:5376:0624/030439.930:INFO:media_foundation_video_encode_accelerator_win.cc(353)] Windows versions earlier than 8 are not supported. [4848:4476:0624/030439.977:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 ../../chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc(278): error: Value of: signin_current_profile_button()->HasFocus() Actual: false Expected: true Stack trace: Backtrace: StackTraceGetter::CurrentStackTrace [0x01F11864+40] testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x01F19F7B+69] testing::internal::AssertHelper::operator= [0x01F19BE0+48] ProfileChooserViewExtensionsTest_SigninButtonHasFocus_Test::RunTestOnMainThread [0x01C9928E+438] content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x03D55408+420] ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x04C3CEB2+3244] ChromeBrowserMainParts::PreMainMessageLoopRun [0x04C3C148+166] content::BrowserMainLoop::PreMainMessageLoopRun [0x029D0F36+68] content::StartupTaskRunner::RunAllTasksNow [0x02D2074C+30] content::BrowserMainLoop::CreateStartupTasks [0x029CFECD+783] content::BrowserMainRunnerImpl::Initialize [0x029D315F+107] content::BrowserMain [0x029CE268+160] content::RunBrowserProcessMain [0x03C20F96+186] content::ContentMainRunnerImpl::Run [0x03C217B3+459] service_manager::Main [0x042E27DE+1198] content::ContentMain [0x03C20E83+51] content::BrowserTestBase::SetUp [0x03D5519A+1872] No obvious culprits. tangltom@ could you take a look at this since you recently made changes in https://crrev.com/c5604690c12b5b998c137d6e67c46b5d1d7c626b ?
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59f9ca3aafef7c661eb833e1f1ddb0bb1f2d3870 commit 59f9ca3aafef7c661eb833e1f1ddb0bb1f2d3870 Author: Darren Shen <shend@chromium.org> Date: Mon Jun 25 05:21:19 2018 Disable ProfileChooserViewExtensionsTest.SigninButtonHasFocus Flaky on Windows TBR=tangltom@chromium.org Bug: 855867 Change-Id: I32be5fa7473203dea8ab3dc25fbb9b5b68edd737 Reviewed-on: https://chromium-review.googlesource.com/1113087 Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#569968} [modify] https://crrev.com/59f9ca3aafef7c661eb833e1f1ddb0bb1f2d3870/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
,
Jun 25 2018
I think the problem lies in the assignment in https://cs.corp.google.com/clankium/src/chrome/browser/ui/views/profiles/profile_chooser_view.cc?q=profilechooserview&dr=CSs&l=580 because we don't set it here: https://cs.corp.google.com/clankium/src/chrome/browser/ui/views/profiles/profile_chooser_view.cc?q=profilechooserview&dr=CSs&l=1169 We return signin_current_profile_button_ instead of checking if signin_with_gaia_account_button_ is set for the personalized Dice promos. I'll work a fix.
,
Jun 27 2018
Removing Sheriff-Chromium since a fix is under way.
,
Sep 17
,
Dec 18
Issue 916155 has been merged into this issue.
,
Dec 19
Do you think this will get fixed soon? If not, can you disable the test? It has failed twice in the last 12 hours: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/30080 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64/30091
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9f3701325e8d3c82922ca2a995d7453fa04eb73 commit b9f3701325e8d3c82922ca2a995d7453fa04eb73 Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Dec 19 14:49:49 2018 Disable flaky test in ProfileChooserViewExtensionsTest ProfileChooserViewExtensionsTest.SigninButtonHasFocus is disabled on Windows, because it is flaky. TBR=thestig@chromium.org Bug: 855867 Change-Id: Ic5607a151862fbb5e74237c6917b5140a85500f1 Reviewed-on: https://chromium-review.googlesource.com/c/1384524 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#617827} [modify] https://crrev.com/b9f3701325e8d3c82922ca2a995d7453fa04eb73/chrome/browser/ui/views/profiles/profile_chooser_view_browsertest.cc
,
Dec 19
Sorry, I lost track of this bug. In the end I don't think comment 4 is the issue and I can't really debug it because I don't have a Windows machine, so I disabled the flaky test. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, Jun 24 2018