New issue
Advanced search Search tips

Issue 855859 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
vamshi.kommuri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

GN fail on arm64 as target_cpu

Reported by halton....@gmail.com, Jun 23 2018 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36

Steps to reproduce the problem:
1.  Check out refs/heads/master@{#569871} on Linux 
2. ./build/linux/sysroot_scripts/install-sysroot.py --arm64
3. gn gen --args="is_component_build=false is_debug=false target_cpu=\"arm64\"" out/linux_arm64_non_component_release

What is the expected behavior?
gn can successfully generate the ninja files

What went wrong?
 gn gen --args="is_component_build=false is_debug=false target_cpu=\"arm64\"" out/linux_arm64_non_component_release
ERROR at //chrome/installer/linux/BUILD.gn:418:7: Assertion failed.
      assert(false, "Linux installer not configured for this architecture.")
      ^-----
Linux installer not configured for this architecture.
See //chrome/installer/linux/BUILD.gn:523:1: whence it was called.
linux_package("stable") {
^------------------------
See //chrome/installer/BUILD.gn:18:7: which caused the file to be included.
      "//chrome/installer/linux",
      ^-------------------------

Did this work before? N/A 

Chrome version: 67.0.3396.87  Channel: canary
OS Version: OS X 10.13.5
Flash Version:
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8501eb9084e1f881e65abf5e10cd26bde07cf5d

commit a8501eb9084e1f881e65abf5e10cd26bde07cf5d
Author: Halton Huo <halton.huo@gmail.com>
Date: Mon Jun 25 03:46:53 2018

Fix GN error on ARM64.

Bug:  855859 
Change-Id: Iaa0733f8c897d13323cf88c88e77d28f7892e3e2
Reviewed-on: https://chromium-review.googlesource.com/1113028
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569956}
[modify] https://crrev.com/a8501eb9084e1f881e65abf5e10cd26bde07cf5d/AUTHORS
[modify] https://crrev.com/a8501eb9084e1f881e65abf5e10cd26bde07cf5d/chrome/installer/linux/BUILD.gn

Comment 2 by vamshi.kommuri@chromium.org, Jun 25 2018

Cc: vamshi.kommuri@chromium.org
Labels: Triaged-ET Needs-Triage-M67 Needs-Feedback
@Halton Huo: Could you please let us know if this can be marked as Fixed, as the fix has landed(...in C#1) if there isn't anything to be done here further.

Thanks...!

Comment 3 by halton....@gmail.com, Jun 25 2018 

Yes, it can be marked as fixed.
Project Member

Comment 4 by sheriffbot@chromium.org, Jun 25 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by vamshi.kommuri@chromium.org, Jun 26 2018

Status: Fixed (was: Unconfirmed)
As per comment#3 marking this issue as Fixed.

Thanks!
►

Sign in to add a comment