New issue
Advanced search Search tips

Issue 855853 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: 2018-07-02
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in extensions::AppBindingsCore::GetIsInstalled

Project Member Reported by ClusterFuzz, Jun 23 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5240876419514368

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  extensions::AppBindingsCore::GetIsInstalled
  extensions::IsInstalledGetterCallback
  v8::internal::PropertyCallbackArguments::BasicCallNamedGetterCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=569276:569278

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5240876419514368

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 23 2018

Components: Blink>JavaScript Platform>Extensions
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 23 2018

Labels: OS-Linux
Project Member

Comment 3 by ClusterFuzz, Jun 23 2018

Labels: Test-Predator-Auto-Owner
Owner: rdevlin....@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/0ef734f4659e2af652b6846e073be226cd11de6d ([Extensions Bindings] Add a fieldtrial testing config entry for native bindings).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
 Issue 856446  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e97d4edaae46e5bce1a00c0ac5a67859edfb155d

commit e97d4edaae46e5bce1a00c0ac5a67859edfb155d
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Fri Jun 29 01:38:50 2018

[Extensions Bindings] Gracefully handle invalidated contexts in app hooks

Handle the case of a context being invalidated before accessing
chrome.app.isInstalled. This can happen in cases where the owning frame
is removed.

Add a regression test for the same.

Bug:  855853 
Change-Id: Ic9e5f5a45fc2a833c5c1a45d3b7c1e8c04c71a18
Reviewed-on: https://chromium-review.googlesource.com/1119066
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571355}
[modify] https://crrev.com/e97d4edaae46e5bce1a00c0ac5a67859edfb155d/chrome/browser/extensions/chrome_app_api_browsertest.cc
[modify] https://crrev.com/e97d4edaae46e5bce1a00c0ac5a67859edfb155d/chrome/renderer/extensions/app_hooks_delegate.cc

NextAction: 2018-07-02
This should be fixed with #5, but I'm curious if clusterfuzz will detect it.
Project Member

Comment 7 by ClusterFuzz, Jun 29 2018

Labels: OS-Mac
Project Member

Comment 8 by ClusterFuzz, Jun 29 2018

ClusterFuzz has detected this issue as fixed in range 571353:571355.

Detailed report: https://clusterfuzz.com/testcase?key=5240876419514368

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_chrome_no_sandbox
Platform Id: windows

Crash Type: Null-dereference READ
Crash Address: 0x000000000020
Crash State:
  extensions::AppBindingsCore::GetIsInstalled
  extensions::IsInstalledGetterCallback
  v8::internal::PropertyCallbackArguments::BasicCallNamedGetterCallback
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=569276:569278
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome_no_sandbox&range=571353:571355

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5240876419514368

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jun 29 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5240876419514368 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
The NextAction date has arrived: 2018-07-02

Sign in to add a comment