New issue
Advanced search Search tips

Issue 855851 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

chrome.permissions does not add a previously enabled origin when a new permission is being requested with that same origin

Reported by royx...@gmail.com, Jun 23 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3471.0 Safari/537.36

Steps to reproduce the problem:
1. Install the attached extension

2. The Options Page will open

3. Please click the "Enable Download" button to confirm that this button is really making a request for both Downloads and origins <all_urls> (e.g. "Read and change all your data on the websites you visit"). Please "Deny" it (this step was just to confirm what this button is requesting).

4. Now click the "Enable Enhanced Mode" button. This button is only making a request for origins <all_urls>. Please Allow.

5. You'll now see a "Disable Enhanced Mode" button where the Enable button was. Please click that button to remove the origins <all_urls>.

6. Please now click the "Enable Download" button again. The prompt should only state that a new additional permission "Manage your Downloads" is being requested. Please Allow this time.

7. Close the Options popup and view the Extension Details Permissions to observe that only the "Manage your Downloads" permission had been added when it was supposed to also add the origins <all_urls> ("Read and change all your data on the websites you visit").

What is the expected behavior?
After clicking the Enable Download button, the two permissions: "Read and change all your data on the websites you visit" (origins <all_urls>) and "Manage your Downloads" should have been added

What went wrong?
Only the "Manage your Downloads" permission was added

WebStore page: 

Did this work before? N/A 

Chrome version: 69.0.3471.0  Channel: n/a
OS Version: 10.0
Flash Version: 

Other Notes:
This behavior only happens when a new permission is being added (when a prompt is displayed).  e.g. If you try disabling and enabling Download again (no prompt will show), you'll see that it gets the <all_urls> origins the second time, which is what we initially wanted.

The two buttons make specifically the following permissions/origins requests:

Enable Download Button:
"request": {permissions: ["downloads"], origins: ["<all_urls>"]}

Enable Enhanced Mode Button:
"request": {origins: ["<all_urls>"]}
 
chrome-permissions-test.zip
18.3 KB Download
Labels: Needs-Triage-M69
Cc: viswa.karala@chromium.org
Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome latest stable# 67.0.3396.99 and on latest chrome# 69.0.3486.0 using Windows-10, Ubuntu 14.04 and Mac 10.12.6. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.

Thanks!
Cc: rdevlin....@chromium.org
Owner: karandeepb@chromium.org
Status: Assigned (was: Untriaged)
karandeepb@, can you take a look?

Sign in to add a comment