New issue
Advanced search Search tips

Issue 855849 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !current.Value().IsInheritedValue() in style_resolver.cc

Project Member Reported by ClusterFuzz, Jun 23 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6427461261459456

Fuzzer: marty_html_twiddler
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !current.Value().IsInheritedValue() in style_resolver.cc
  void blink::StyleResolver::ApplyProperties<
  void blink::StyleResolver::ApplyMatchedProperties<
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=569866:569867

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6427461261459456

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 23 2018

Components: Blink>CSS
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: kkaluri@chromium.org
Labels: M-69 Test-Predator-Wrong
Owner: rjwright@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "style_resolver.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://chromium.googlesource.com/chromium/src/+/3f8c27eb8613c697da176a322c3d1078b45aaa4e

rjwright@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Owner: futhark@chromium.org
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4295e527b3aa6eb627527ede6de273ed1029c428

commit 4295e527b3aa6eb627527ede6de273ed1029c428
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Jun 27 08:28:20 2018

Handle explicit inherit for non-allowed :visited properties.

There was a DCHECK making sure we did not cached matched properties when
one of the applied properties was a non-inherited property with an
explicit inherit value. For :visited properties, we do not set the flag
for properties which are not allowed, but re-applying it to the cached
ComputedStyle later would trigger a DCHECK even if the inherit value
would not actually be applied. Applied changes to the DCHECK to handle
that case.

Also took the chance to Ribbonize valid :visited/:link properties as
IsValidForVisitedLink().

Bug:  855849 
Change-Id: I0addbd969cfd71e7f177ed5afbd5eac088800dee
Reviewed-on: https://chromium-review.googlesource.com/1114977
Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570695}
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property.h.tmpl
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/build/scripts/core/css/properties/templates/css_property_subclass.h.tmpl
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/core/css/resolver/matched_properties_cache.h
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/core/css/resolver/style_builder.cc
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/core/css/resolver/style_resolver.cc
[modify] https://crrev.com/4295e527b3aa6eb627527ede6de273ed1029c428/third_party/blink/renderer/core/css/style_engine_test.cc

Project Member

Comment 6 by ClusterFuzz, Jun 28 2018

ClusterFuzz has detected this issue as fixed in range 570692:570693.

Detailed report: https://clusterfuzz.com/testcase?key=6427461261459456

Fuzzer: marty_html_twiddler
Job Type: linux_debug_chrome
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !current.Value().IsInheritedValue() in style_resolver.cc
  void blink::StyleResolver::ApplyProperties<
  void blink::StyleResolver::ApplyMatchedProperties<
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=569866:569867
Fixed: https://clusterfuzz.com/revisions?job=linux_debug_chrome&range=570692:570693

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6427461261459456

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jun 28 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6427461261459456 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment