New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855834 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
OOO Jan 14 - 25
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

There is a blank area in the new tab when I don't use Google as my default search engine.

Reported by white.bl...@gmail.com, Jun 23 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.33 Safari/537.36

Steps to reproduce the problem:
1. Go to chrome://settings/ and do not set Google as the search engine
2. Go to the new tab, try scrolling down

What is the expected behavior?
There is not a scroll bar, and you can't scroll down.

What went wrong?
You can scroll down, and see that there is a blank area.

Did this work before? N/A 

Chrome version: 68.0.3440.33  Channel: beta
OS Version: 10.0
Flash Version:
 
Labels: Needs-Triage-M68
Labels: Triaged-ET Needs-Feedback
Unable to reproduce the issue on chrome reported version# 68.0.3440.3 using Windows-10 with steps mentioned below:
1) Launched chrome reported version and navigated to chrome://settings and changed yahoo as default search engine
2) Opened New Tab Page, didn't observed any white area

@Reporter: Could you please try to test this issue by creating new person with no apps and extensions in it and let us know if the issue still persists.

Thanks!

Comment 3 by woxxom@gmail.com, Jun 27 2018

The problem is easily reproducible in a new profile with any search engine that doesn't add its own content.
For example, add a new search engine with a name "123", keyword "123", URL "http://123/%s"

Bisected to 87cb6bc677f7665addec684361c25dfda1e22e3f "Revert changes in css files to hide rows of MV tiles."
Landed in 67.0.3369.0

Thanks. I created a new person, changing Yahoo as default search engine and the white area still persists.
And woxxom is right. Every search engine that does not create something in the new tab will produce such a problem.
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 27 2018

Cc: viswa.karala@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
 Issue 857246  has been merged into this issue.
Components: -UI UI>Browser>NewTabPage
Labels: -Type-Bug -Pri-2 Target-67 M-68 RegressedIn-67 FoundIn-67 Target-68 Target-69 FoundIn-69 FoundIn-68 hasbisect OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: ramyan@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, mac 10.13.3 and Ubuntu 17.10 using chrome reported version #68.0.3440.33 and latest canary #69.0.3487.0.

Bisect Information:
=====================
Good build: 67.0.3368.0
Bad Build : 67.0.3369.0

As per comment #3, suspecting the below change:
Change-Id: I336351f35077cacecf4682bddfa47322db882eba
Reviewed-on: https://chromium-review.googlesource.com/950105

ramyan@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-68 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!
Cc: yyushkina@chromium.org kristip...@chromium.org
This seems to be due to left & top positioning for .non-google-page #ntp-contents, and seems to be solvable by explicitly setting height there (rather than letting it inherit from ntp-contents. I'll test that this also looks good on Pixelbook before sending out a cl.
Status: Started (was: Assigned)
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7886601e76bc2be1d43b5185ba102513f33b0dc

commit e7886601e76bc2be1d43b5185ba102513f33b0dc
Author: Ramya Nagarajan <ramyan@chromium.org>
Date: Fri Jul 13 20:25:47 2018

[NTP] Explicitly set ntp-contents height for non-google-page.

If this is not set, the #ntp-contents height is inherited, which applies
from the "top" location specified in .non-google-page, but using the
size of the overall NTP content area (at 100%), resulting in an
unnecessary scrollbar. The chosen height corresponds to MV tile height
for a single row, but also works for a row of icons, and works well on
small screens (like Pixelbook), as well as high-res screens.

Bug:  855834 

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8b342e066c8ddcb51b51e9f03a85e9181a001020
Reviewed-on: https://chromium-review.googlesource.com/1136860
Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575053}
[modify] https://crrev.com/e7886601e76bc2be1d43b5185ba102513f33b0dc/chrome/browser/resources/local_ntp/local_ntp.css

Labels: -Pri-1 Pri-2
Status: Fixed (was: Started)
This would mean a late merge in M68, and its severity and impact doesn't seem to warrant that. The fix will be available in M69.
Labels: TE-Verified-69.0.3493.0 TE-Verified-M69
Able to reproduce the issue on Mac 10.13.3 using chrome reported version #68.0.3440.33

Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using latest chrome version #69.0.3493.0 as per the comment #0 and #3.
Attaching screen cast for reference.
Observed that there is not a scroll bar, and the page can't be scroll down.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
855834.mp4
384 KB View Download
Cc: swarnasree.mukkala@chromium.org
 Issue 877845  has been merged into this issue.

Sign in to add a comment