New issue
Advanced search Search tips

Issue 855816 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 874695
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 855135



Sign in to add a comment

"virtual/stable/http/tests/navigation/rename-subframe-goback.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 23 2018

Issue description

"virtual/stable/http/tests/navigation/rename-subframe-goback.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySwsSBUZsYWtlIkB2aXJ0dWFsL3N0YWJsZS9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVuYW1lLXN1YmZyYW1lLWdvYmFjay5odG1sDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by shend@chromium.org, Jun 25 2018

Disabling test in https://crrev.com/c/1113161.

Comment 2 by shend@chromium.org, Jun 25 2018

Cc: japhet@chromium.org
Owner: lukasza@chromium.org
Status: Assigned (was: Untriaged)
Not really sure who owns tests/navigation. lukasza@, could you help triage? Thank you.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b4dea4e71a8d2793710b645cc9f10024c68c083

commit 3b4dea4e71a8d2793710b645cc9f10024c68c083
Author: Darren Shen <shend@chromium.org>
Date: Mon Jun 25 10:07:52 2018

Disable rename-subframe-goback.html

virtual/stable/http/tests/navigation/rename-subframe-goback.html
times out on Linux.

TBR=lukasza@chromium.org

Bug:  855816 
Change-Id: I56234dcc8c4adab0d2539a751467131fd2b8ceeb
Reviewed-on: https://chromium-review.googlesource.com/1113161
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569997}
[modify] https://crrev.com/3b4dea4e71a8d2793710b645cc9f10024c68c083/third_party/WebKit/LayoutTests/TestExpectations

Blockedon: 855135
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26659aafba00ddb477fb7c05a7cda372e57192bc

commit 26659aafba00ddb477fb7c05a7cda372e57192bc
Author: Kenneth Russell <kbr@chromium.org>
Date: Tue Jun 26 02:25:13 2018

Suppress flaky layout tests.

 fast/events/context-no-deselect.html
  - Suppress on all platforms, not just Windows.

 external/wpt/service-workers/service-worker/
    about-blank-replacement.https.html
  - Timing out in main and virtual test suites.

 http/tests/navigation/rename-subframe-goback.html
  - Fix linked bug ID.

Bug: 663847,  855816 ,  856330 
Change-Id: If2178c22714e64f6cd76267323f26634a18f9347
Tbr: alph@chromium.org
Tbr: tkent@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1114132
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570302}
[modify] https://crrev.com/26659aafba00ddb477fb7c05a7cda372e57192bc/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Mergedinto: 874695
Status: Duplicate (was: Assigned)
Let's dedupe this bug to a more recent one, where some discussion happened recently.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2592c9eaa7ec5f8406c0a95e41c54f456b03c3ad

commit 2592c9eaa7ec5f8406c0a95e41c54f456b03c3ad
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Wed Sep 12 09:44:36 2018

TestExpectations: A flaky test is so not only on Win7, but also on Win10

rename-subframe-goback.html was marked for Win7, but it is flaky
even on Win10 for newly added virtual tests. Since this should not
be a feature specific, let's change it mark for Win so to affect
Win10 too.

See also Findit's comment on a CL below.
https://chromium-review.googlesource.com/c/chromium/src/+/1193524

Bug:  855816 , 870173
Change-Id: I3fdc95e335fcd42b88be6957151e59c92563c5dd
Tbr: yhirano@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1220952
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590629}
[modify] https://crrev.com/2592c9eaa7ec5f8406c0a95e41c54f456b03c3ad/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment