New issue
Advanced search Search tips

Issue 855802 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: 1
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 822037



Sign in to add a comment

Maximized caption buttons too tall in refresh

Project Member Reported by pkasting@chromium.org, Jun 23 2018

Issue description

On Win 10, the maximized mode caption buttons are 34 px high (at 100%).  This looks really tall.  Edge is 31 px.  Windows Explorer is 21 px.

The code in Windows10CaptionButton::CalculatePreferredSize() returns 29 in restored mode and "tab strip height - 2" in maximized mode.  Probably maximized mode should be std::max(restored height, tab strip height - 2)?  Not sure where the 29 comes from.  Not sure if DWMWA_CAPTION_BUTTON_BOUNDS or SM_CYSIZE could help us compute the right "native" values here?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e106b88031ec373f185794081f9226a67613a4f7

commit e106b88031ec373f185794081f9226a67613a4f7
Author: Bret Sepulveda <bsep@chromium.org>
Date: Wed Jun 27 19:57:36 2018

Ensure caption button height for maximized windows isn't too large.

Pre-Refresh a maximized window had a very condensed tabstrip, so it made
sense to set Windows 10's caption button height to (slightly less than)
the tabstrip height. Refresh tabs are much taller though, so now they
look way too big. This patch caps their height at the restored height,
since that's what Windows does in the same case.

Bug:  855802 
Change-Id: I305491442462a8979388cb78e0be3975d9f1c88f
Reviewed-on: https://chromium-review.googlesource.com/1116188
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570873}
[modify] https://crrev.com/e106b88031ec373f185794081f9226a67613a4f7/chrome/browser/ui/views/frame/windows_10_caption_button.cc

Comment 2 by bsep@chromium.org, Jun 27 2018

Status: Fixed (was: Assigned)
Labels: Group-Window_Frame

Sign in to add a comment