New issue
Advanced search Search tips

Issue 855799 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 846020
issue 863525



Sign in to add a comment

Use luci-config for configuring crosskylabadmin app

Project Member Reported by pprabhu@chromium.org, Jun 23 2018

Issue description

'cause its the right thing to do.
 
Blocking: 846020
Cc: bpastene@chromium.org tandrii@chromium.org
Follow this?
https://github.com/luci/luci-py/blob/master/appengine/config_service/README.md
no, that doc is for setting luci-config itself.

I think in your case, you may follow how luci-migration app is using luci-config:

https://cs.chromium.org/chromium/infra/go/src/infra/appengine/luci-migration/config/?sq=package:chromium&dr=CSs&g=0
Blocking: 863525
Status: Started (was: Assigned)
Labels: -Pri-2 Pri-1
Blocking staging setup.
Summary: Use luci-config for configuring crosskylabadmin app (was: Use luci-config for configuration crosskylabadmin app)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/20b22c4f546931d25e78cde2f8d4e3658f92dc6c

commit 20b22c4f546931d25e78cde2f8d4e3658f92dc6c
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed Jul 25 19:09:27 2018

Must setup luci-config to recognize each service following https://cs.chromium.org/chromium/infra/luci/appengine/config_service/doc/README.md

Also, must setup cron jobs on the tenant service following https://godoc.org/github.com/luci/luci-go/appengine/gaemiddleware#hdr-Cron_setup
protip: Head over to https://chromeos-skylab-bot-fleet.appspot.com/admin/portal  to setup various chops service configuration that lives with the tenant service.

It has the best documentation for what is needed for luci-config as well.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/c83e3d79afe59f72db525f388be0d519d0746d5d

commit c83e3d79afe59f72db525f388be0d519d0746d5d
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Wed Aug 01 19:46:40 2018

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/74620687bb975167e594bd10e9b0b9a3ffa6ecbe

commit 74620687bb975167e594bd10e9b0b9a3ffa6ecbe
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Aug 02 00:47:57 2018

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/d09c5ef97340d95252fc45871bb0c9b99b9dba95

commit d09c5ef97340d95252fc45871bb0c9b99b9dba95
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Aug 02 18:19:41 2018

Project Member

Comment 16 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1dbd18ba1a7eb6b347c7c0e6d9617840ac9fc02b

commit 1dbd18ba1a7eb6b347c7c0e6d9617840ac9fc02b
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Aug 02 18:41:52 2018

crosskylabadmin: Fix bug in installing service handlers

BUG= chromium:855799 

Change-Id: I4889b1a014a38ac395e64c2ecbc5c4fef16529af
Reviewed-on: https://chromium-review.googlesource.com/1161045
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/1dbd18ba1a7eb6b347c7c0e6d9617840ac9fc02b/go/src/infra/appengine/crosskylabadmin/app/frontend/frontend.go

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6

commit fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Thu Aug 02 23:47:14 2018

crosskylabadmin: Use configuration injected via luci-config

BUG= chromium:855799 

Change-Id: I6ceab99498f941844cbec1d947f0a3fe1ed7860a
Reviewed-on: https://chromium-review.googlesource.com/1157134
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/frontend/tasker.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/cron/cron.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/frontend/tasker_test.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/frontend/tracker_test.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/frontend/frontend.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/config/config.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/frontend/test_common.go
[modify] https://crrev.com/fa7f6d23ebf6f638123acb4feaf8ab2e2cb611c6/go/src/infra/appengine/crosskylabadmin/app/frontend/tracker.go

Thanks to vadimsh@ as part of this effort, crosskylabadmin now works from the devserver. local develpment ftw!

This is done in essence. Have to push ToT versions to prod/staging and declare victory.
Status: Fixed (was: Started)

Sign in to add a comment