BrowserViewTest suite is failing on Linux under Refresh |
|||
Issue descriptionThis is a new failure since I started fixing tests a couple weeks ago. Passes on other platforms. Here's a link to a failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/125239 We bisected and found crrev.com/c/1105772 as the culprit, so I'm reverting. I'm not totally sure how it caused the failure; the root cause could be a bug in the test URL resolver posting on the wrong task runner, or something. Please fix before relanding. Full list of failing tests: BrowserViewTest.AccessibleWindowTitle BrowserViewTest.BrowserViewLayout BrowserViewTest.BookmarkBarInvisibleOnShutdown BrowserViewTest.RepeatedAccelerators BrowserViewTest.BrowserView BrowserNonClientFrameViewTabbedTest.HitTestTabstrip
,
Jun 26 2018
,
Jun 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7141db77bcc81dcb4f8a27038723027b89f3fe44 commit 7141db77bcc81dcb4f8a27038723027b89f3fe44 Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Jun 27 08:46:47 2018 Show promo account icon in toolbar when user is signed out Relanding crrev.com/c/1105772 after crbug.com/855797 . Broken tests caused by calls to GetAccountsForDicePromos were fixed. When the user is signed out of Chrome and the profile icon has not been explicitly changed, AvatarToolbarButton now uses the account icon of the first sync promo account. Screenshots: https://drive.google.com/file/d/1a7kr12KtA11Wt7MQ9MLnSf-M3D9nlLdg/view?usp=sharing https://drive.google.com/file/d/1nKLnoD1sbcZOvwGQY3YtHVTUv32DQNFn/view?usp=sharing TBR=droger@chromium.org TBR=tapted@chromium.org TBR=bsep@chromium.org Bug: 853363 , 855797 Change-Id: I830aedd32c30cb1c39fc24551dd225c81d62c097 Reviewed-on: https://chromium-review.googlesource.com/1112253 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#570699} [modify] https://crrev.com/7141db77bcc81dcb4f8a27038723027b89f3fe44/chrome/browser/ui/views/frame/test_with_browser_view.cc [modify] https://crrev.com/7141db77bcc81dcb4f8a27038723027b89f3fe44/chrome/browser/ui/views/frame/test_with_browser_view.h [modify] https://crrev.com/7141db77bcc81dcb4f8a27038723027b89f3fe44/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc [modify] https://crrev.com/7141db77bcc81dcb4f8a27038723027b89f3fe44/chrome/browser/ui/views/profiles/avatar_toolbar_button.h
,
Jun 28 2018
,
Jun 28 2018
Sorry for having to pull the rug from under your feet. Thanks for fixing it Tom! |
|||
►
Sign in to add a comment |
|||
Comment 1 by pbos@chromium.org
, Jun 25 2018