New issue
Advanced search Search tips

Issue 855788 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Clean up credit card upload send detected values experiment

Project Member Reported by jsaul@google.com, Jun 22 2018

Issue description

Original implementation bug:  crbug.com/789645 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cc21b97481af52b3e5b26d48075142f1c2906f4

commit 6cc21b97481af52b3e5b26d48075142f1c2906f4
Author: Jared Saul <jsaul@google.com>
Date: Tue Jun 26 00:58:19 2018

Remove usage of AutofillUpstreamSendDetectedValues experiment flag

The "send detected values" experiment was launched in M65 and has been
default-enabled at ToT for a while now.  We've delayed removing the flag code
because it (correctly) resulted in a QPS increase for Payments, but things have
gone well, so I'm now removing the flag and making the behavior default.

Bug:  855788 
Change-Id: If34db8ac090732cbdc44cfec17f2530d22b00e04
Reviewed-on: https://chromium-review.googlesource.com/1112753
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570274}
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/chrome/browser/about_flags.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/chrome/browser/ui/views/autofill/save_card_bubble_views_browsertest_base.h
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/autofill_experiments.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/autofill_experiments.h
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/credit_card_save_manager.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/credit_card_save_manager.h
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/credit_card_save_manager_unittest.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/form_data_importer.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/payments/payments_client.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/components/autofill/core/browser/payments/payments_client_unittest.cc
[modify] https://crrev.com/6cc21b97481af52b3e5b26d48075142f1c2906f4/tools/metrics/histograms/enums.xml

Comment 2 by jsaul@google.com, Jun 26 2018

Status: Fixed (was: Assigned)

Sign in to add a comment