New issue
Advanced search Search tips

Issue 855787 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jun 2018
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Bug



Sign in to add a comment

transform-origin accepts illegal value

Project Member Reported by ericwilligers@chromium.org, Jun 22 2018 
Blink currently accepts transform-origin 'top 1px' and serializes it as 'center top 1px'.

'top 1px' is not a legal value according to the grammar in
https://drafts.csswg.org/css-transforms/#transform-origin-property

  [ left | center | right | top | bottom | <length-percentage> ]
| 
  [ left | center | right | <length-percentage> ]
  [ top | center | bottom | <length-percentage> ] <length>?
|
  [[ center | left | right ] && [ center | top | bottom ]] <length>?


Edge/Firefox/WebKit all correctly reject the value.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a735176e25cf3765534a54db79e92454dc693066

commit a735176e25cf3765534a54db79e92454dc693066
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Mon Jun 25 19:44:34 2018

CSS: transform-origin does not accept top <length>

Spec:
https://drafts.csswg.org/css-transforms/#propdef-transform-origin

Blink no longer accepts transform-origin 'top 1px'. We previously
parsed it as 'top center 1px'.

Edge/Firefox/WebKit already reject such values.

BUG= 855787 

Change-Id: I8ac8745d41c867a2ef659ce9afe17143d60a1806
Reviewed-on: https://chromium-review.googlesource.com/1112883
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570139}
[modify] https://crrev.com/a735176e25cf3765534a54db79e92454dc693066/third_party/WebKit/LayoutTests/external/wpt/css/css-images/parsing/gradient-position-invalid.html
[modify] https://crrev.com/a735176e25cf3765534a54db79e92454dc693066/third_party/WebKit/LayoutTests/transforms/transform-origin-parsing.html
[modify] https://crrev.com/a735176e25cf3765534a54db79e92454dc693066/third_party/blink/renderer/core/css/parser/css_property_parser_helpers.cc

Comment 2 by ericwilligers@chromium.org, Jun 25 2018

Owner: ericwilligers@chromium.org
Status: Fixed (was: Untriaged)
►

Sign in to add a comment