CL at https://chromium-review.googlesource.com/c/chromium/src/+/1112730

Orin has volunteered to merge and land this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04c08b43a8e78f2d0452e3ef4334c07a88083d69

commit 04c08b43a8e78f2d0452e3ef4334c07a88083d69
Author: Orin Jaworski <orinj@chromium.org>
Date: Wed Jul 11 02:39:56 2018

[omnibox] Reverse (swap) the rows on answers (other than definitions)

This CL will swap the two rows of an answer/entity if the
answers are excepted.  It is a duplicate of change at
crrev.com/c/1112730 but with merge conflict resolved and
owner changed.

Bug:  855783 
Change-Id: I17950c6daa489d7b42c0954195f4bf823383e31b
Reviewed-on: https://chromium-review.googlesource.com/1132550
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574044}
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/chrome/browser/about_flags.cc
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/04c08b43a8e78f2d0452e3ef4334c07a88083d69/tools/metrics/histograms/enums.xml

orinj@ - Could you please provide manual repro steps to verify the issue from TE-end.

Thanks...!!

krajshree: you can verify the change above by enabling chrome://flags/#upcoming-ui-features, producing a weather answer, and confirming that the temperature appears on the first row (in stable it's the second row).

But note that this work is not finished so you might want to hold off until we report it Fixed.

What's landed will reverse the rows on all answer types except for definitions.  There's more work for styling in progress, but the reversals can be checked now.  To verify:

Clear all flags to default in Chrome canary, but enable these:
* chrome://flags/#upcoming-ui-features
* chrome://flags/#omnibox-new-answer-layout
* chrome://flags/#omnibox-reverse-answers

Restart Chrome.

Go for some answers in omnibox using search queries like these:

- definition      (dictionary) "define set point"
- sunrise/sunset  (sunrise)    "sunrise in los angeles"
- stock           (finance)    "abc stock price"
- time            (when_is)    "when is <holiday>"
- currency        (currency)   "33 dollars in British pounds"
- calculator            (?)    "3+5"
- knowledge answers     (?)    "how old is <person>"
- translate             (?)    "hello in Japanese"

Note, currently the calculator result is not considered an 'answer' like the other types.  And definitions are explicitly excepted from the line reversal.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d17b33bd25e0ce11a333ecee45bf43b63580ea

commit d5d17b33bd25e0ce11a333ecee45bf43b63580ea
Author: Orin Jaworski <orinj@chromium.org>
Date: Tue Jul 17 01:25:13 2018

[omnibox] Reverse answer content & description, with styling

This CL changes the way answers reverse content and description
fields (the position/layout approach was incomplete). Font sizes
and colors are also applied to answers according to redline spec.

Bug:  855783 
Change-Id: I39d619bbb729d2637f08d9c37fdfd5fb4938361a
Reviewed-on: https://chromium-review.googlesource.com/1137341
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575510}
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/chrome/browser/ui/omnibox/omnibox_theme.cc
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.cc
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/chrome/browser/ui/views/omnibox/omnibox_match_cell_view.h
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/chrome/browser/ui/views/omnibox/omnibox_text_view.cc
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/chrome/browser/ui/views/omnibox/omnibox_text_view.h
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/components/omnibox/browser/autocomplete_match.cc
[modify] https://crrev.com/d5d17b33bd25e0ce11a333ecee45bf43b63580ea/components/omnibox/browser/autocomplete_match.h

This is visually correct in today's Canary (69.0.3495.0) but there are a couple follow-up changes that orinj is working on. Leaving this open for those but at a lower priority.

Correction: the follow-on changes were tracked at  https://crbug.com/838733 .