A number of browser_tests fail with OopAsh |
|||
Issue descriptionHere's the list: AppWindowApiTest.OnRestoredEvent LauncherPlatformAppBrowserTest.WindowActivation ShelfAppBrowserTest.LaunchMaximized LauncherPlatformAppBrowserTest.PackagedAppClickBehaviorInMinimizeMode LauncherPlatformAppBrowserTest.UnpinRunning SystemWebDialogTest.ModalTest ShelfAppBrowserTest.AltNumberTabsTabbing ShelfAppBrowserTest.MatchingShelfIDandActiveTab ShelfAppBrowserTest.RefocusFilterLaunch ShelfAppBrowserTestNoDefaultBrowser.BrowserShortcutLauncherItemController ShelfAppBrowserTest.LaunchPinned ShelfAppBrowserTest.TabDragAndDrop ShelfAppBrowserTest.AppWindowRestoreBehaviorTest LauncherPlatformAppBrowserTest.AltNumberAppsTabbing SystemWebDialogTest.NonModalTest LauncherPlatformAppBrowserTest.BrowserActivation ShelfAppBrowserTest.Navigation LauncherPlatformAppBrowserTest.WindowAttentionStatus LauncherPlatformAppBrowserTest.LaunchPinned ShelfAppBrowserTestNoDefaultBrowser.AltNumberBrowserTabbing ShelfAppBrowserTest.ActivateAfterSessionRestore ShelfBrowserTest.StatusBubble That many shelf related ones are failing is interesting and would imply something isn't working that the shelf relies on. Maybe it's focus/activation related? Not sure.
,
Jul 10
The list is now much smaller: ShelfAppBrowserTest.AltNumberTabsTabbing AppWindowApiTest.OnRestoredEvent ShelfAppBrowserTestNoDefaultBrowser.BrowserShortcutLauncherItemController LoginWebDialogTest.CloseDialogByAccelerator LauncherPlatformAppBrowserTest.PackagedAppClickBehaviorInMinimizeMode ShelfAppBrowserTestNoDefaultBrowser.AltNumberBrowserTabbing LauncherPlatformAppBrowserTest.AltNumberAppsTabbing
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/360626addbfc77a51083bf8f05d023e132aa6e76 commit 360626addbfc77a51083bf8f05d023e132aa6e76 Author: Scott Violet <sky@chromium.org> Date: Wed Jul 11 15:55:50 2018 chromeos: renames kMash to kMashDeprecated and kOopAsh to kMash This also removes mash_ash_unittests as it's no longer applicable. There is a lot of cleanup that can happen, but I'm leaving that for future patches in hopes of not making this one too big. BUG= 855767 842365 840391 TEST=covered by tests Change-Id: If97385dc0e0b65974b8773043da55d576ff3d1fb Reviewed-on: https://chromium-review.googlesource.com/1131924 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574181} [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/BUILD.gn [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/README.md [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accelerators/accelerator_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accessibility/accessibility_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/accessibility/accessibility_highlight_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/app_list/views/search_result_answer_card_view.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ash_service.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ash_service.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/display_color_manager.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/display_synchronizer.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/mirror_window_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/display/window_tree_host_manager.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/drag_drop/drag_drop_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/host/ash_window_tree_host_platform.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/ime/ime_focus_handler_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/keyboard/virtual_keyboard_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/keyboard/virtual_keyboard_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/magnifier/magnification_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/pointer_watcher_adapter_classic_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/public/cpp/config.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/root_window_controller.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf_window_watcher.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shelf/shelf_window_watcher_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shell.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/shell_port_mash.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/flag_warning/flag_warning_tray_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/network_list.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/tray_network_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/network/wifi_toggle_notification_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/power/power_event_observer.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/system/unified/unified_system_tray_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_base.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_helper.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/test/ash_test_suite.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/touch/touch_observer_hud_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/lock_state_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/non_client_frame_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/overview/window_selector_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/splitview/split_view_controller_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/window_util.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/wm_toplevel_window_event_handler.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ash/wm/workspace/workspace_layout_manager_unittest.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/chrome/browser/ash_service_registry.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/chrome/utility/mash_service_factory.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/mash/test/mash_test_suite.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/services/ui/demo/mus_demo_unittests.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/services/ui/ws/window_server_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/chromium.memory.json [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/filters/BUILD.gn [delete] https://crrev.com/b954c230264648522a5e7f96812b174cd74276f9/testing/buildbot/filters/mash.ash_unittests.filter [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/filters/mash.browser_tests.filter [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/testing/buildbot/test_suites.pyl [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/mus/window_tree_client.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/mus/window_tree_client.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_base.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_helper.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/aura_test_helper.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/test_window_tree_client_setup.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/test_window_tree_client_setup.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/mus/window_tree_client_private.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/aura/test/test_screen.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/base/ui_base_features.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/base/ui_base_features.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/aura_init.cc [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/mus_client.h [modify] https://crrev.com/360626addbfc77a51083bf8f05d023e132aa6e76/ui/views/mus/views_mus_test_suite.cc
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd2556851e3cf048df2cbebfbfa2a2633e89e786 commit bd2556851e3cf048df2cbebfbfa2a2633e89e786 Author: Scott Violet <sky@chromium.org> Date: Wed Jul 11 20:08:50 2018 chromeos: disable LoginWebDialogTest.CannotMinimize for mash_browser_tests as it's flaky. BUG= 855767 TEST=none TBR=msw@chromium.org Change-Id: Ib0952cdb6aed73556784e9002d2a364d2120fbf7 Reviewed-on: https://chromium-review.googlesource.com/1134051 Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#574298} [modify] https://crrev.com/bd2556851e3cf048df2cbebfbfa2a2633e89e786/testing/buildbot/filters/mash.browser_tests.filter
,
Jul 11
Here's the failure from LoginWebDialogTest.CannotMinimize: #0 0x7f7323a5757d base::debug::StackTrace::StackTrace() #1 0x7f732376dafc base::debug::StackTrace::StackTrace() #2 0x7f73237d74fd logging::LogMessage::~LogMessage() #3 0x7f7315898a42 aura::Window::AddChild() #4 0x7f730f68fe9a ash::WindowServiceDelegateImpl::SetModalType() #5 0x7f730c32d330 ui::ws2::WindowTree::SetModalTypeImpl() #6 0x7f730c3337e2 ui::ws2::WindowTree::SetModalType() #7 0x7f730c3f2137 ui::mojom::WindowTreeStubDispatch::Accept() #8 0x7f730c3583b3 ui::mojom::WindowTreeStub<>::Accept() #9 0x7f731e65df85 mojo::InterfaceEndpointClient::HandleValidatedMessage() #10 0x7f731e65ca41 mojo::InterfaceEndpointClient::HandleIncomingMessageThunk::Accept() #11 0x7f731e65aef8 mojo::FilterChain::Accept() #12 0x7f731e660916 mojo::InterfaceEndpointClient::HandleIncomingMessage() #13 0x7f731e66cd32 mojo::internal::MultiplexRouter::ProcessIncomingMessage() #14 0x7f731e66c355 mojo::internal::MultiplexRouter::Accept() #15 0x7f731e65aef8 mojo::FilterChain::Accept() #16 0x7f731e64db32 mojo::Connector::ReadSingleMessage() #17 0x7f731e64eaba mojo::Connector::ReadAllAvailableMessages() #18 0x7f731e64e888 mojo::Connector::OnHandleReadyInternal() #19 0x7f731e64e78b mojo::Connector::OnWatcherHandleReady() #20 0x7f731e651fbf _ZN4base8internal13FunctorTraitsIMN4mojo9ConnectorEFvjEvE6InvokeIS5_PS3_JjEEEvT_OT0_DpOT1_ #21 0x7f731e651eef _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKMN4mojo9ConnectorEFvjEJPS5_jEEEvOT_DpOT0_ #22 0x7f731e651e85 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEEOj #23 0x7f731e651dbb _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo9ConnectorEFvjEJNS0_17UnretainedWrapperIS4_EEEEEFvjEE3RunEPNS0_13BindStateBaseEj #24 0x7f731e6493ae _ZNKR4base17RepeatingCallbackIFvjEE3RunEj #25 0x7f731e65113f mojo::SimpleWatcher::DiscardReadyState() #26 0x7f731e6513bf _ZN4base8internal13FunctorTraitsIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEvE6InvokeIRKSC_JS6_jSA_EEEvOT_DpOT0_ #27 0x7f731e65135d _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS8_jSC_EEEvOT_DpOT0_ #28 0x7f731e651300 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS5_EEEFvjSB_EE7RunImplIRKSD_RKNSt3__15tupleIJS5_EEEJLm0EEEEvOT_OT0_NSK_16integer_sequenceImJXspT1_EEEEOjSB_ #29 0x7f731e651236 _ZN4base8internal7InvokerINS0_9BindStateIPFvRKNS_17RepeatingCallbackIFvjEEEjRKN4mojo18HandleSignalsStateEEJS5_EEEFvjSB_EE3RunEPNS0_13BindStateBaseEjSB_ #30 0x7f7323d4680e _ZNKR4base17RepeatingCallbackIFvjRKN4mojo18HandleSignalsStateEEE3RunEjS4_ #31 0x7f7323d4617b mojo::SimpleWatcher::OnHandleReady() #32 0x7f7323d46fc3 _ZN4base8internal13FunctorTraitsIMN4mojo13SimpleWatcherEFvijRKNS2_18HandleSignalsStateEEvE6InvokeIS8_RKNS_7WeakPtrIS3_EEJRKiRKjS6_EEEvT_OT0_DpOT1_ #33 0x7f7323d46f05 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN4mojo13SimpleWatcherEFvijRKNS4_18HandleSignalsStateEERKNS_7WeakPtrIS5_EEJRKiRKjS8_EEEvOT_OT0_DpOT1_ #34 0x7f7323d46e62 _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE7RunImplIRKS9_RKNSt3__15tupleIJSB_ijS5_EEEJLm0ELm1ELm2ELm3EEEEvOT_OT0_NSI_16integer_sequenceImJXspT1_EEEE #35 0x7f7323d46cdc _ZN4base8internal7InvokerINS0_9BindStateIMN4mojo13SimpleWatcherEFvijRKNS3_18HandleSignalsStateEEJNS_7WeakPtrIS4_EEijS5_EEEFvvEE3RunEPNS0_13BindStateBaseE #36 0x7f732371f24e _ZNO4base12OnceCallbackIFvvEE3RunEv #37 0x7f732376eeea base::debug::TaskAnnotator::RunTask() #38 0x7f7323801d30 base::MessageLoop::RunTask() #39 0x7f7323801f75 base::MessageLoop::DeferOrRunPendingTask() #40 0x7f732380229f base::MessageLoop::DoWork() #41 0x7f7323a9bdeb base::MessagePumpLibevent::Run() #42 0x7f732380161e base::MessageLoop::Run() #43 0x7f73238a9122 base::RunLoop::Run() #44 0x7f731c052ff1 content::UtilityMain() #45 0x7f731c0807d2 content::RunOtherNamedProcessTypeMain() #46 0x7f731c082dad content::ContentMainRunnerImpl::Run() #47 0x7f731c0775dc content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #48 0x7f7314fb2161 service_manager::Main() #49 0x7f731c07d755 content::ContentMain() #50 0x0000079b7cb9 content::LaunchTests() #51 0x00000668325a LaunchChromeTests() #52 0x00000668179b main This may be impacting others.
,
Jul 11
Hmm, not sure why re-parenting the system modal dialog to the system modal container wouldn't work, but I'll take a look at some point soon.
,
Jul 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d9f316a0ba47bb4be158db0de5edc596272dabe commit 1d9f316a0ba47bb4be158db0de5edc596272dabe Author: Scott Violet <sky@chromium.org> Date: Wed Jul 11 22:17:20 2018 chromeos: fix infinite loop in cursor lookup And remove a NOTREACHED that we're hitting. I will supply a test for this separate, as well as investgating removal of NOREACHED. BUG= 855767 TEST=none Change-Id: Idf59b80388fefa06317a70055d18db995187c9a0 Reviewed-on: https://chromium-review.googlesource.com/1134352 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#574371} [modify] https://crrev.com/1d9f316a0ba47bb4be158db0de5edc596272dabe/services/ui/ws2/window_delegate_impl.cc [modify] https://crrev.com/1d9f316a0ba47bb4be158db0de5edc596272dabe/services/ui/ws2/window_delegate_impl.h
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/094e26dcce3074a8fb2287b2fd0f306f0aa3289d commit 094e26dcce3074a8fb2287b2fd0f306f0aa3289d Author: James Cook <jamescook@chromium.org> Date: Tue Oct 16 23:04:58 2018 chromeos: Fix ShelfAppBrowserTest under SingleProcessMash ShelfAppBrowserTest.LaunchAppFromDisplayWithoutFocus0 and ShelfAppBrowserTest.LaunchAppFromDisplayWithoutFocus1 cannot assume a browser window's root window is the display's root window. Check display IDs instead. Bug: 855767 Change-Id: I5a5486b82502bf8d4d0d9f9ff19231a4a3d93b61 Reviewed-on: https://chromium-review.googlesource.com/c/1285081 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600170} [modify] https://crrev.com/094e26dcce3074a8fb2287b2fd0f306f0aa3289d/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc [modify] https://crrev.com/094e26dcce3074a8fb2287b2fd0f306f0aa3289d/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Oct 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca27e1827ddc420ae37764004a93bab0cda5eb1b commit ca27e1827ddc420ae37764004a93bab0cda5eb1b Author: James Cook <jamescook@chromium.org> Date: Wed Oct 17 23:35:41 2018 chromeos: Trigger window bounce animations via mojo call to ash This fixes several shelf browser_tests under SingleProcessMash. It also makes the window bounce animations include the window frame, not just the content area. Bug: 855767 Test: browser_tests ShelfApp* Change-Id: I2d09d7162104bfb65c7a51507304f71a92d87377 Reviewed-on: https://chromium-review.googlesource.com/c/1287183 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600598} [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/ash/public/interfaces/ash_window_manager.mojom [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/ash/ws/ash_window_manager.cc [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/ash/ws/ash_window_manager.h [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/chrome/browser/ui/ash/ash_util.cc [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/chrome/browser/ui/ash/ash_util.h [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/services/ws/window_tree.cc [modify] https://crrev.com/ca27e1827ddc420ae37764004a93bab0cda5eb1b/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2ace16eff51f3a77a9e303652fff7f96633369e commit f2ace16eff51f3a77a9e303652fff7f96633369e Author: James Cook <jamescook@chromium.org> Date: Thu Oct 18 19:04:26 2018 Enable shelf AltNumber*Tabbing tests on mash FYI bot They were fixed by crrev.com/600598 that moved window bounce animations to ash. Bug: 855767 Change-Id: I5a711a6a93966ef30ce410138f4b13b3f1da039f Reviewed-on: https://chromium-review.googlesource.com/c/1289290 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600850} [modify] https://crrev.com/f2ace16eff51f3a77a9e303652fff7f96633369e/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter
,
Oct 19
These are all due to a bug with window visibility. sky and I have a fix.
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d485dc5c3e4e4793033fda8e50b223a75740ba56 commit d485dc5c3e4e4793033fda8e50b223a75740ba56 Author: James Cook <jamescook@chromium.org> Date: Fri Oct 19 23:13:54 2018 chromeos: Pass visibility state changes to client This fixes a problem with restoring minimized windows. The client needs to know that the window is not visible to know that it is allowed to restore it. Fixes the following tests: -AppWindowApiTest.OnRestoredEvent -BrowserActionApiTest.BrowserActionPopupWithIframe -FirstRunUIBrowserTest.ModalWindowDoesNotBlock -LauncherPlatformAppBrowserTest.PackagedAppClickBehaviorInMinimizeMode -LoginWebDialogTest.CannotMinimize -LoginWebDialogTest.CloseDialogByAccelerator -ShelfAppBrowserTestNoDefaultBrowser.BrowserShortcutLauncherItemController Bug: 855767 Test: added to services_unittests Change-Id: Icb1a12e4dd18f68807bf0dc9140ce289e9ea913c Reviewed-on: https://chromium-review.googlesource.com/c/1292053 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#601349} [modify] https://crrev.com/d485dc5c3e4e4793033fda8e50b223a75740ba56/services/ws/client_change.h [modify] https://crrev.com/d485dc5c3e4e4793033fda8e50b223a75740ba56/services/ws/window_tree.cc [modify] https://crrev.com/d485dc5c3e4e4793033fda8e50b223a75740ba56/services/ws/window_tree.h [modify] https://crrev.com/d485dc5c3e4e4793033fda8e50b223a75740ba56/services/ws/window_tree_unittest.cc [modify] https://crrev.com/d485dc5c3e4e4793033fda8e50b223a75740ba56/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter [modify] https://crrev.com/d485dc5c3e4e4793033fda8e50b223a75740ba56/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
,
Oct 19
,
Oct 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b52658efc355f0dbabdfc843c1ad665055d6f29 commit 7b52658efc355f0dbabdfc843c1ad665055d6f29 Author: Evan Stade <estade@chromium.org> Date: Mon Oct 22 17:11:00 2018 Mash: remove some passing browser tests from filter file Bug: 855767 Change-Id: I6dfefc7aa5a8934ee41ae1ca07e15eabe5685377 Reviewed-on: https://chromium-review.googlesource.com/c/1292724 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#601623} [modify] https://crrev.com/7b52658efc355f0dbabdfc843c1ad665055d6f29/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter |
|||
►
Sign in to add a comment |
|||
Comment 1 by jamescook@chromium.org
, Jul 3