New issue
Advanced search Search tips

Issue 855762 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Build crosvm cpu and memory usage metrics

Project Member Reported by timzheng@chromium.org, Jun 22 2018

Issue description


We want to measure how much cpu and memory of the device is used by VMs that host a Linux container.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/6f2a472327712d09a31259ef4c29dd0e2dd70ea7

commit 6f2a472327712d09a31259ef4c29dd0e2dd70ea7
Author: Tim Zheng <timzheng@google.com>
Date: Sat Jul 28 05:33:26 2018

metrics: Get all crosvm processes.

This change add functions to get a list of all crosvm processes. This is
going to be used to tabulate resource usage metrics for crosvm.

BUG= chromium:855762 
TEST=manually tested on an eve device.

Change-Id: Ica84f2eca8c741d0e38eccad86f66a4bd4d759a8
Reviewed-on: https://chromium-review.googlesource.com/1148653
Commit-Ready: Tim Zheng <timzheng@chromium.org>
Tested-by: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/6f2a472327712d09a31259ef4c29dd0e2dd70ea7/metrics/metrics.gyp
[add] https://crrev.com/6f2a472327712d09a31259ef4c29dd0e2dd70ea7/metrics/crosvm_process_list.cc
[add] https://crrev.com/6f2a472327712d09a31259ef4c29dd0e2dd70ea7/metrics/crosvm_process_list.h
[add] https://crrev.com/6f2a472327712d09a31259ef4c29dd0e2dd70ea7/metrics/crosvm_process_list_test.cc

Labels: M-70
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dccfef24739d2ab6964373d68af746f6ad6bdf94

commit dccfef24739d2ab6964373d68af746f6ad6bdf94
Author: Tim Zheng <timzheng@chromium.org>
Date: Fri Aug 17 18:17:46 2018

Revert "metrics: Get all crosvm processes."

This reverts commit 6f2a472327712d09a31259ef4c29dd0e2dd70ea7.

Reason for revert: <Implementation is redone in the Chromium repo.>

Original change's description:
> metrics: Get all crosvm processes.
>
> This change add functions to get a list of all crosvm processes. This is
> going to be used to tabulate resource usage metrics for crosvm.
>
> BUG= chromium:855762 
> TEST=manually tested on an eve device.
>
> Change-Id: Ica84f2eca8c741d0e38eccad86f66a4bd4d759a8
> Reviewed-on: https://chromium-review.googlesource.com/1148653
> Commit-Ready: Tim Zheng <timzheng@chromium.org>
> Tested-by: Tim Zheng <timzheng@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>

Bug:  chromium:855762 
Change-Id: I4f47f668d362c2ffaa256202f5deaf836cfc4b9d
Reviewed-on: https://chromium-review.googlesource.com/1176378
Commit-Ready: Tim Zheng <timzheng@chromium.org>
Tested-by: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/dccfef24739d2ab6964373d68af746f6ad6bdf94/metrics/metrics.gyp
[delete] https://crrev.com/f2057117f8879144a5266d05e2331c1294559588/metrics/crosvm_process_list.cc
[delete] https://crrev.com/f2057117f8879144a5266d05e2331c1294559588/metrics/crosvm_process_list.h
[delete] https://crrev.com/f2057117f8879144a5266d05e2331c1294559588/metrics/crosvm_process_list_test.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e96a626064602f3d8d29179fa96cc2f9f3222072

commit e96a626064602f3d8d29179fa96cc2f9f3222072
Author: Tim Zheng <timzheng@google.com>
Date: Tue Aug 21 20:44:44 2018

Build crosvm CPU memory usage histograms.

This change add 3 histograms for measuring crosvm resource usage, namely
CPU percentage, resident memory percentage, and number of crosvm
processes.

BUG= chromium:855762 
TEST=manually tested on an eve device; unit tests included.

Change-Id: I55f442505a340813db4eb6047844288e4801f325
Reviewed-on: https://chromium-review.googlesource.com/1175410
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584891}
[modify] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/crostini/crosvm_metrics.cc
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/crostini/crosvm_metrics.h
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/crostini/crosvm_metrics_unittest.cc
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/crostini/crosvm_process_list.cc
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/crostini/crosvm_process_list.h
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/crostini/crosvm_process_list_unittest.cc
[modify] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/power/process_data_collector.cc
[modify] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/power/process_data_collector_unittest.cc
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/system/procfs_util.cc
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/system/procfs_util.h
[add] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/chrome/browser/chromeos/system/procfs_util_unittest.cc
[modify] https://crrev.com/e96a626064602f3d8d29179fa96cc2f9f3222072/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Cc: jopra@chromium.org timzheng@chromium.org tbuck...@chromium.org jkardatzke@chromium.org
 Issue 872620  has been merged into this issue.
Cc: rohi...@chromium.org avkodipelli@chromium.org
Status: Verified (was: Fixed)

Sign in to add a comment