New issue
Advanced search Search tips

Issue 855749 link

Starred by 1 user
Status: Fixed
Owner:
atotic@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

[LayoutNG] Fail to layout everything with 'position: absolute' child inside inline block

Project Member Reported by xiaoche...@chromium.org, Jun 22 2018 
Chrome Version: ToT @ r569737

Load the attached file with LayoutNG enabled. We hit a DCHECK:

[1:1:0622/144014.703946:FATAL:layout_object.h(356)] Security DCHECK failed: !NeedsLayout(). 
#0 0x000003bdf02c base::debug::StackTrace::StackTrace()
#1 0x000003b58e7b logging::LogMessage::~LogMessage()
#2 0x000005ca1125 blink::LocalFrameView::UpdateLayout()
#3 0x000005975947 blink::Document::ImplicitClose()
#4 0x000005975346 blink::Document::CheckCompleted()
#5 0x0000062b98c6 blink::FrameLoader::FinishedParsing()
#6 0x000005982312 blink::Document::FinishedParsing()
#7 0x000005d9426a blink::HTMLConstructionSite::FinishedParsing()
#8 0x000005df3f84 blink::HTMLTreeBuilder::Finished()
#9 0x000005d81d76 blink::HTMLDocumentParser::end()
#10 0x000005d7bf48 blink::HTMLDocumentParser::AttemptToRunDeferredScriptsAndEnd()
#11 0x000005d7be01 blink::HTMLDocumentParser::PrepareToStopParsing()
#12 0x000005d7eedb blink::HTMLDocumentParser::ProcessTokenizedChunkFromBackgroundParser()
#13 0x000005d7cbba blink::HTMLDocumentParser::PumpPendingSpeculations()
#14 0x000005d7c6f9 blink::HTMLDocumentParser::ResumeParsingAfterYield()
#15 0x000003027e50 WTF::ThreadCheckingCallbackWrapper<>::Run()
#16 0x0000055e485a blink::TaskHandle::Runner::Run()
positioned-inline-block-crash.html
183 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9f23bc591dc3499da590353ddc8f48c8db73d64

commit b9f23bc591dc3499da590353ddc8f48c8db73d64
Author: Aleks Totic <atotic@chromium.org>
Date: Tue Jun 26 17:36:23 2018

[LayoutNG] Fix never positioned OOF block crash

Thanks xiaochengh for filing this bug.

Bug:  855749 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib0e53b94573872baccef84eddbfa341163190646
Reviewed-on: https://chromium-review.googlesource.com/1114341
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570447}
[modify] https://crrev.com/b9f23bc591dc3499da590353ddc8f48c8db73d64/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/b9f23bc591dc3499da590353ddc8f48c8db73d64/third_party/blink/renderer/core/layout/ng/inline/ng_inline_box_state.cc
[modify] https://crrev.com/b9f23bc591dc3499da590353ddc8f48c8db73d64/third_party/blink/renderer/core/layout/ng/inline/ng_inline_layout_algorithm.cc
[modify] https://crrev.com/b9f23bc591dc3499da590353ddc8f48c8db73d64/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.cc
[modify] https://crrev.com/b9f23bc591dc3499da590353ddc8f48c8db73d64/third_party/blink/renderer/core/layout/ng/ng_container_fragment_builder.h

Comment 2 by atotic@chromium.org, Jun 26 2018

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61ce408c0640907f3bf23c75df09422889f53a97

commit 61ce408c0640907f3bf23c75df09422889f53a97
Author: Aleks Totic <atotic@chromium.org>
Date: Wed Jun 27 04:56:18 2018

Rebaseline

Following tests had always failing baselines because of font mismatches
(except for extend_by_character.html with is a text test
with failing baseline checked in).

fast/writing-mode/vertical-rl-replaced-selection.html
compositing/reflections/nested-reflection-transition.html
compositing/reflections/nested-reflection-animated.html
compositing/reflections/nested-reflection-anchor-point.html
scrollbars/overflow-scrollbar-combinations.html
fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
fast/forms/text/input-text-scroll-left-on-blur.html
svg/as-background-image/svg-as-background-5.html
editing/selection/modify_extend/extend_by_character.html
fast/text/selection/emphasis.html
editing/selection/modify_extend/extend_by_character.html
fast/text/selection/emphasis-vertical.html


Bug:  855749 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I5e62dced67a857e844af3baa760fd6b63fb0e723
Reviewed-on: https://chromium-review.googlesource.com/1115510
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570662}
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/compositing/reflections/nested-reflection-transition-expected.png
[add] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/editing/selection/modify_extend/extend_by_character-expected.txt
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-text-scroll-left-on-blur-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-text-scroll-left-on-blur-expected.txt
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/fast/text/selection/emphasis-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/fast/writing-mode/vertical-rl-replaced-selection-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/scrollbars/overflow-scrollbar-combinations-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/linux/svg/as-background-image/svg-as-background-5-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/reflections/nested-reflection-anchor-point-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-text-scroll-left-on-blur-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/compositing/reflections/nested-reflection-anchor-point-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/mac-mac10.11/compositing/reflections/nested-reflection-animated-expected.png
[add] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[add] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-text-scroll-left-on-blur-expected.png
[add] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/text/input-text-scroll-left-on-blur-expected.txt
[add] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac-mac10.12/fast/text/selection/emphasis-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/mac-retina/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/compositing/reflections/nested-reflection-transition-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-text-scroll-left-on-blur-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-text-scroll-left-on-blur-expected.txt
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/fast/text/selection/emphasis-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/fast/writing-mode/vertical-rl-replaced-selection-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/scrollbars/overflow-scrollbar-combinations-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/mac/svg/as-background-image/svg-as-background-5-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-anchor-point-expected.txt
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-animated-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/compositing/reflections/nested-reflection-transition-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-text-scroll-left-on-blur-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-text-scroll-left-on-blur-expected.txt
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/fast/text/selection/emphasis-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/fast/writing-mode/vertical-rl-replaced-selection-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/scrollbars/overflow-scrollbar-combinations-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win/svg/as-background-image/svg-as-background-5-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/win7/compositing/reflections/nested-reflection-anchor-point-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/win7/compositing/reflections/nested-reflection-animated-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/win7/compositing/reflections/nested-reflection-transition-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/win7/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win7/fast/text/selection/emphasis-expected.png
[delete] https://crrev.com/c902c1774b0c5864c3920b5759cf0a3d12f37438/third_party/WebKit/LayoutTests/platform/win7/scrollbars/overflow-scrollbar-combinations-expected.png
[modify] https://crrev.com/61ce408c0640907f3bf23c75df09422889f53a97/third_party/WebKit/LayoutTests/platform/win7/svg/as-background-image/svg-as-background-5-expected.png
►

Sign in to add a comment