New issue
Advanced search Search tips

Issue 855739 link

Starred by 0 users
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Jul 17
Cc:
mlamouri@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 825890



Sign in to add a comment

Add metrics for Display Cutout

Project Member Reported by beccahughes@chromium.org, Jun 22 2018 
Add four metrics for DC:

 - UKM: Layout.DisplayCutout.Requested
 - UseCounter (exposed to UKM): WebFeature::kMediaControlsDisplayCutoutGesture_Expand and pinch
 - UseCounter (exposed to UKM): WebFeature::kCSSEnvironmentVariable
   and one for each safe area inset.

Comment 1 by beccahughes@chromium.org, Jun 22 2018

Description: Show this description

Comment 2 by beccahughes@chromium.org, Jun 22 2018

Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7

commit c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jun 28 15:56:52 2018

[CSS Env Vars] Add WebFeatures for env()

Add WebFeature UseCounters for when env() is used and for when
each safe area inset variable is used.

These should also be exposed to UKM so we can cross reference
with our UKM event.

BUG= 855739 

Change-Id: Ib5e4f26752a279c9696a050bd42dd5842fe28cb0
Reviewed-on: https://chromium-review.googlesource.com/1112698
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571144}
[modify] https://crrev.com/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
[modify] https://crrev.com/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7/third_party/blink/renderer/core/css/document_style_environment_variables.cc
[modify] https://crrev.com/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7/third_party/blink/renderer/core/css/document_style_environment_variables.h
[modify] https://crrev.com/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7/third_party/blink/renderer/core/css/style_environment_variables_test.cc
[modify] https://crrev.com/c1fe3ed23515496bf6bda97b6ccd6b82bdd55fe7/tools/metrics/histograms/enums.xml
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f8d87b828ea394dbabae37c56b25d7e382abb6a

commit 7f8d87b828ea394dbabae37c56b25d7e382abb6a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Jun 28 23:06:55 2018

[Display Cutout] Add UseCounter for DC gesture

Add UseCounter metrics for the Display Cutout pinch
gesture and expose to UKM so we can cross reference
events together.

BUG= 855739 

Change-Id: I89da2effa938380fad5b065ede01e6b757ee17ca
Reviewed-on: https://chromium-review.googlesource.com/1112724
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571314}
[modify] https://crrev.com/7f8d87b828ea394dbabae37c56b25d7e382abb6a/chrome/browser/page_load_metrics/observers/use_counter/ukm_features.cc
[modify] https://crrev.com/7f8d87b828ea394dbabae37c56b25d7e382abb6a/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/7f8d87b828ea394dbabae37c56b25d7e382abb6a/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate.cc
[modify] https://crrev.com/7f8d87b828ea394dbabae37c56b25d7e382abb6a/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate_test.cc
[modify] https://crrev.com/7f8d87b828ea394dbabae37c56b25d7e382abb6a/tools/metrics/histograms/enums.xml

Comment 5 by e...@chromium.org, Jul 1

Labels: -Type-Bug Type-Feature
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4439ab774e1e5c8733575160dd1eff3494260d

commit 7c4439ab774e1e5c8733575160dd1eff3494260d
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jul 02 22:45:59 2018

[CSS Env Vars] Do not record metrics on media controls

The media controls are using env() which is causing
pages using the media controls to record UseCounter
metrics for env().

This CL silences the metrics if the TreeScope when
resolving the variables is a UA shadow root.

BUG= 855739 

Change-Id: I48a17e426511021e29d6ff6d4f5e535eafbd2b24
Reviewed-on: https://chromium-review.googlesource.com/1123299
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572028}
[modify] https://crrev.com/7c4439ab774e1e5c8733575160dd1eff3494260d/third_party/blink/renderer/core/css/document_style_environment_variables.cc
[modify] https://crrev.com/7c4439ab774e1e5c8733575160dd1eff3494260d/third_party/blink/renderer/core/css/document_style_environment_variables.h
[modify] https://crrev.com/7c4439ab774e1e5c8733575160dd1eff3494260d/third_party/blink/renderer/core/css/resolver/css_variable_resolver.cc
[modify] https://crrev.com/7c4439ab774e1e5c8733575160dd1eff3494260d/third_party/blink/renderer/core/css/style_environment_variables_test.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40c880a85a2016fdffbe83d06ee9727160f50647

commit 40c880a85a2016fdffbe83d06ee9727160f50647
Author: Becca Hughes <beccahughes@chromium.org>
Date: Mon Jul 09 23:01:03 2018

[Display Cutout] Add a kCoverForcedByUserAgent

Add a kCoverForcedByUserAgent ViewportFit value which is used
when the media controls are forcing kCover. The value will
behave exactly the same as kCover but being seperate will
allow us to track it seperately in metrics.

BUG= 855739 

Change-Id: I7cf8418f190b47cf1e04d5dc461448a4df5234ed
Reviewed-on: https://chromium-review.googlesource.com/1117766
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573503}
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTest.java
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTestRule.java
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/chrome/android/junit/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutControllerTest.java
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/third_party/blink/public/mojom/page/display_cutout.mojom
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/third_party/blink/renderer/core/dom/document_test.cc
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/third_party/blink/renderer/core/frame/viewport_data.cc
[modify] https://crrev.com/40c880a85a2016fdffbe83d06ee9727160f50647/third_party/blink/renderer/modules/media_controls/media_controls_display_cutout_delegate_test.cc

Comment 8 by beccahughes@chromium.org, Jul 17

Status: Fixed (was: Started)
►

Sign in to add a comment