New issue
Advanced search Search tips

Issue 855729 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
M-X

Blocked on:
issue 857281

Blocking:
issue 822061
issue 822063



Sign in to add a comment

Add flags for close buttons on inactive tabs & NTB position

Project Member Reported by pkasting@chromium.org, Jun 22 2018

Issue description

Let's add temporary about:flags entries for whether inactive tabs hide close buttons by default and where the NTB is positioned.  This will help in design experiments/decision-making.
 
EstimatedDays: 1
Labels: Hotlist-Helper
Labels: -Hotlist-Helper
Owner: kylixrd@chromium.org
Status: Assigned (was: Untriaged)
NTB configuration work is done, we just need to add it to chrome://flags.
Similarly, close buttons need to be added to chrome://flags.

Both above per conversation on configurability.
Blockedon: 857281
Labels: M-X
Owner: ----
Status: Available (was: Assigned)
If we need to add a flag for close buttons, let's split that out of this bug.

Comment 4 by stan...@gmail.com, Jun 28 2018

I'd suggesting making this a normal UI option, users are very used to their new tab button position and in general dislike change so why not make it an option defaulting to the value that the design dept. deems optimal?
We're not going to be moving the NTB from the position users are used to, so if the motivation for suggesting "make it an option" is "let me put my NTB back", that's very shortly going to be moot.
Status: Started (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 29 2018

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/630979171b981ffefd07c1e31036f322b6cb03f1

commit 630979171b981ffefd07c1e31036f322b6cb03f1
Author: Peter Kasting <pkasting@chromium.org>
Date: Sat Jun 30 02:09:03 2018

Change NTB default position to AFTER_TABS, add flags, remove Finch control.

I'm not opposed to leaving this under Finch control for future experimentation,
but I don't really know how to use FEATURE_WITH_PARAMS_VALUE.

Bug:  857610 ,  857282 ,  855729 
Change-Id: Ibe1b9c13003f2da78b241e775f37b2e9ab7e71f7
Reviewed-on: https://chromium-review.googlesource.com/1119362
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571739}
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/about_flags.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/common/chrome_switches.cc
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/chrome/common/chrome_switches.h
[modify] https://crrev.com/630979171b981ffefd07c1e31036f322b6cb03f1/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)
Labels: Group-Design

Sign in to add a comment