New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855728 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

metrics_python_tests filter argument interacts weirdly with typ

Project Member Reported by martiniss@chromium.org, Jun 22 2018

Issue description

https://chromium-review.googlesource.com/c/chromium/src/+/1109400 was an attempt to make metrics_python_tests be able to run a subset of its tests.

It turns out that it can't do this, because of the way typ is being used by the test suite. It already selects a set of tests to run, which means that typ ignores the argument I'm passing, in https://cs.chromium.org/chromium/src/third_party/catapult/third_party/typ/typ/runner.py?q=typ/runner.py&sq=package:chromium&g=0&l=396

Dirk, do you know why this is the case? Can this be changed? I would think the easiest change would be to change the code in typ, but I'd be worried it'd break other code, since that code looks to have been around for years.
 
Yeah, I'll need to think about this, I think that's a combination I haven't accounted for, but it should be easy enough to handle.
Labels: Build-Tools-TYP
Components: Tests
Labels: -Pri-3 Pri-2
Ping!

I feel like I saw a conversation with kbr and dirk about this somewhere, but I did a search in my email and didn't see anything. Is this still an issue?
Yes, this is still an issue.
Blocking: -533481

Sign in to add a comment