New issue
Advanced search Search tips

Issue 855727 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 11
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Download OCP : Add implementation for OpenDownload

Project Member Reported by shaktisahu@chromium.org, Jun 22 2018

Issue description

The downloads should provide an implementation for OfflineContentProvider::OpenDownload() which for android will go to Java and fire an intent.

May be use ChromeDownloadManagerDelegate::OpenDownload() to do this.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfb8d519057e94487e4e0a863481403ffd331ce4

commit cfb8d519057e94487e4e0a863481403ffd331ce4
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Jun 29 19:12:26 2018

Downloads : Implemented OCP::OpenItem

Provided implementation for DownloadOfflineContentProvider::OpenItem. It
will call DownloadItem::OpenDownload and eventually hits
ChromeDownloadManagerDelegate. We will also need to pass DownloadOpenSource
to this interface later for UMA purposes.

Bug:  855727 
Change-Id: I86f4f802ab8711ea2162e512e18cbcbf93c1822f
Reviewed-on: https://chromium-review.googlesource.com/1114068
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571580}
[modify] https://crrev.com/cfb8d519057e94487e4e0a863481403ffd331ce4/chrome/browser/android/download/download_manager_service.cc
[modify] https://crrev.com/cfb8d519057e94487e4e0a863481403ffd331ce4/chrome/browser/android/download/download_manager_service.h
[modify] https://crrev.com/cfb8d519057e94487e4e0a863481403ffd331ce4/chrome/browser/download/chrome_download_manager_delegate.cc
[modify] https://crrev.com/cfb8d519057e94487e4e0a863481403ffd331ce4/chrome/browser/download/download_offline_content_provider.cc

Status: Fixed (was: Started)

Sign in to add a comment