New issue
Advanced search Search tips

Issue 855725 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Password not cleared when switching between auth users

Project Member Reported by jdufault@chromium.org, Jun 22 2018

Issue description

Password not cleared when switching between auth users
 
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86a87223c0d628e55a66d2658838be3436b1e853

commit 86a87223c0d628e55a66d2658838be3436b1e853
Author: Jacob Dufault <jdufault@google.com>
Date: Fri Jun 22 22:04:47 2018

cros: Views login/lock clear password when switching active auth user.

Bug:  855725 
Change-Id: I91f6bab46701c9d66bc8b497661c460a7968619f
Reviewed-on: https://chromium-review.googlesource.com/1112075
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569802}
[modify] https://crrev.com/86a87223c0d628e55a66d2658838be3436b1e853/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/86a87223c0d628e55a66d2658838be3436b1e853/ash/login/ui/login_auth_user_view_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3638035788e7e7acc007b3a465c453caefa54a76

commit 3638035788e7e7acc007b3a465c453caefa54a76
Author: Nico Weber <thakis@chromium.org>
Date: Sat Jun 23 20:50:21 2018

Revert "cros: Views login/lock clear password when switching active auth user."

This reverts commit 86a87223c0d628e55a66d2658838be3436b1e853.

Reason for revert:
ash_unittests LoginAuthUserViewUnittest.PasswordClearedAfterAnimationIfPasswordDisabled
has been failing on linux-chromeos-dbg since this landed in
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6443

Original change's description:
> cros: Views login/lock clear password when switching active auth user.
> 
> Bug:  855725 
> Change-Id: I91f6bab46701c9d66bc8b497661c460a7968619f
> Reviewed-on: https://chromium-review.googlesource.com/1112075
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569802}

TBR=jdufault@chromium.org,xiaoyinh@chromium.org

Change-Id: I7a54ed3ba91ea6a9adb46f83852488ed1c76178c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  855725 
Reviewed-on: https://chromium-review.googlesource.com/1112980
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569882}
[modify] https://crrev.com/3638035788e7e7acc007b3a465c453caefa54a76/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/3638035788e7e7acc007b3a465c453caefa54a76/ash/login/ui/login_auth_user_view_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aecdebfd820a8979f5b89506e527cff5215c425

commit 1aecdebfd820a8979f5b89506e527cff5215c425
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Jun 25 21:06:50 2018

Reland cros: Views login/lock clear password when switching active auth user.

Fixed ASAN issue where an animation sequence was being used after it was
scheduled. In a test, the sequence is destroyed immediately after scheduling.
This was a pre-existing issue exposed by the new test.

Bug:  855725 
Change-Id: I07a475374df775465e4a9f110df6d2759fdf38d6
Reviewed-on: https://chromium-review.googlesource.com/1113997
Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570178}
[modify] https://crrev.com/1aecdebfd820a8979f5b89506e527cff5215c425/ash/login/ui/login_auth_user_view.cc
[modify] https://crrev.com/1aecdebfd820a8979f5b89506e527cff5215c425/ash/login/ui/login_auth_user_view_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment