New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 855723 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Match knowledge suggestions UI to other rich-answers

Project Member Reported by bklmn@chromium.org, Jun 22 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) Search for knowledge result ("how tall is...," "how old is...")

What is the expected result?
Same UI layout as the rich-answers UI (blue circle with white icon inside)

What happens instead?
Current implementation show mono-chrome "G" in blue at full size (see attachments). 

 
Screen Shot 2018-06-22 at 1.12.58 PM.png
296 KB View Download
Group 5.png
22.0 KB View Download

Comment 1 by orinj@chromium.org, Jun 22 2018

This screenshot is taken after encircling and resizing the big G.  I put Group 5.png from above into the image so I could compare with measuring tools.  The only difference I see is the shade of blue, which I think is intentional for Refresh.
UpdatedIconScreenWithOldForComparison.png
45.9 KB View Download

Comment 2 by orinj@chromium.org, Jun 22 2018

Okay, they do look a little different, and on close inspection I see the G in Group 5.png is actually only 14x14px, not 16x16px.  So, bklmn@, are you aiming for G of size 14px as pictured in the bug report, or 16px as discussed today?

Comment 3 by bklmn@chromium.org, Jun 22 2018

Thats right. The asset is 16px, but there is built in padding in the asset for visual balance...so the actual "G" is 14px

Comment 4 by orinj@chromium.org, Jun 22 2018

Very helpful, thanks.  What happened here was the padding got lost in translation, so I will see if I can improve on the conversion process.

Comment 5 by orinj@chromium.org, Jun 22 2018

We made a little mess starting from the 32px version attached to yesterday's email but I found the 16px asset in your share.  Translating that led to this, which appears pixel perfect now.
UpdatedScreenshotWithPaddingPreserved.png
16.4 KB View Download
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e17122e08b957ff7540cc65fdefe75f87c22c42

commit 1e17122e08b957ff7540cc65fdefe75f87c22c42
Author: Orin Jaworski <orinj@chromium.org>
Date: Mon Jun 25 17:24:13 2018

[omnibox] Resize and encircle monochrome G vector icon

The G is made 16x16 within a circle of diameter 24.
This icon is used for default and knowledge graph
answer results.

Bug:  855723 
Change-Id: Ia8b48837208606b4dcf515412b642ad780e16718
Reviewed-on: https://chromium-review.googlesource.com/1112643
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570082}
[modify] https://crrev.com/1e17122e08b957ff7540cc65fdefe75f87c22c42/components/omnibox/browser/vector_icons/answer_default.icon

Cc: phanindra.mandapaka@chromium.org
Labels: Needs-Feedback
Tested this issue on Windows 10 and Mac 10.13.5 on the latest chrome version 69.0.3473.0.

1. Launched Chrome and enabled the flag #omnibox-new-answer-layout and #Omnibox entity suggestions
2. Navigated to new tab and Entered text as given in the comment #0 on omnibox ("how tall is...," "how old is...")
We have not seen the blue circle with white icon inside

@Reporter: Please find the attached screen-cast and let us know if we have missed anything in the process.

Thanks!
855723.mp4
1.2 MB View Download

Comment 9 by orinj@chromium.org, Jun 26 2018

I just tried to repro on official Windows canary 69.0.3473.0 but I *do* get the big mono G icon with answer result.  So maybe it's a Mac-specific problem?  I will ask around to see if someone with a Mac can repro.

Comment 10 by orinj@chromium.org, Jun 26 2018

dpapad@ let me try his Macbook with the same version of Canary.  With all flags reset to default, and with the said flags enabled, suggestions weren't coming through at all, so I couldn't even see whether knowledge answers showed the icon.  Even in chrome://omnibox, queries came back with only one list item for searching what's typed.

The theory at the moment is that some experiments may be interfering.  Is there a way to disable all experiments and get a baseline behavior?  I'd like to side-by-side with as many variables as possible ruled out.  Even better if I can repro on Linux or Windows.

Comment 11 by orinj@chromium.org, Jun 26 2018

Okay, jdonnelly@ got the icon on his Macbook running this version and figured out that the reason it's not showing up in this video is because the necessary flags aren't set.  A hint is that the tabs at top are old-style.  The flag handling changed a week or so ago.  Try resetting all flags to default and then enable #upcoming-ui-features and #omnibox-new-answer-layout - then you should see the updated icon.
Labels: Proj-MdRefresh
Fixed?
Status: Fixed (was: Assigned)
Yeah, I definitely got the mono-G down to size in a circle, a few times. :)  Marking fixed, as I think the comment #8 concern is a non-issue.

Sign in to add a comment