New issue
Advanced search Search tips

Issue 855721 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 825890



Sign in to add a comment

Display Cutout: Send safe areas to fullscreen frame

Project Member Reported by beccahughes@chromium.org, Jun 22 2018

Issue description

Safe area should be sent to the current fullscreen frame and not just the main frame.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2

commit 6daf5668bcb9460aa18fd25fe3442c1de5f36ad2
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Jun 27 16:50:54 2018

[Display Cutout] Refactor safe areas

This refactors the code that sends the safe areas moving
it to WebContentsImpl which will be useful for metrics later
on.

BUG= 855721 

Change-Id: I9d4976ec9bdeddef3b0d8a1a824b8a65f78516ba
Reviewed-on: https://chromium-review.googlesource.com/1112071
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570808}
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/chrome/android/java/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutController.java
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/chrome/browser/BUILD.gn
[delete] https://crrev.com/a40efea15eaf90fcf5f573f3bbb32c193466cf2d/chrome/browser/android/display_cutout/OWNERS
[delete] https://crrev.com/a40efea15eaf90fcf5f573f3bbb32c193466cf2d/chrome/browser/android/display_cutout/display_cutout_controller_android.cc
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/content/public/test/android/javatests/src/org/chromium/content/browser/test/mock/MockWebContents.java
[modify] https://crrev.com/6daf5668bcb9460aa18fd25fe3442c1de5f36ad2/third_party/blink/renderer/controller/blink_initializer.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ef7f454abb02020b47045a999845b9cffdc4a8a

commit 9ef7f454abb02020b47045a999845b9cffdc4a8a
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Jun 27 16:57:31 2018

[Display Cutout] Fix bug to send safe areas to current frame

Fixes a bug where safe areas are only sent to the main frame.
This should be the current fullscreen frame.

BUG= 855721 

Change-Id: I32fcf1190384bd9878711f7ae66e2fb4ea183df4
Reviewed-on: https://chromium-review.googlesource.com/1114144
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570816}
[modify] https://crrev.com/9ef7f454abb02020b47045a999845b9cffdc4a8a/chrome/android/javatests/src/org/chromium/chrome/browser/display_cutout/DisplayCutoutTest.java
[modify] https://crrev.com/9ef7f454abb02020b47045a999845b9cffdc4a8a/content/browser/web_contents/web_contents_impl.cc

Status: Fixed (was: Started)

Sign in to add a comment