[BGPT] Scrolling for a non-existent node |
|||
Issue description
With enable-blink-gen-property-trees virtual/threaded/fast/animationworklet/animation-worklet-scroll-timeline-overflow-hidden.html crashes on a DCHECK
#3 0x000000000b0c9852 in cc::ScrollTimeline::CurrentTime(cc::ScrollTree const&, bool) const (this=0x2b1f0d19da30,
scroll_tree=..., is_active_tree=false) at ../../cc/animation/scroll_timeline.cc:48
#4 0x000000000b0c84a9 in cc::WorkletAnimation::CurrentTime(base::TimeTicks, cc::ScrollTree const&, bool) (this=
0x2b1f0a4c3180, monotonic_time=..., scroll_tree=..., is_active_tree=false)
at ../../cc/animation/worklet_animation.cc:118
#5 0x000000000b0c8390 in cc::WorkletAnimation::NeedsUpdate(base::TimeTicks, cc::ScrollTree const&, bool) (this=0x2b1f0a4c3180, monotonic_time=..., scroll_tree=..., is_active_tree=false) at ../../cc/animation/worklet_animation.cc:135
#6 0x000000000b0c79c1 in cc::WorkletAnimation::UpdateInputState(cc::MutatorInputState*, base::TimeTicks, cc::ScrollTree const&, bool) (this=0x2b1f0a4c3180, input_state=0x2b1f109cee20, monotonic_time=..., scroll_tree=..., is_active_tree=false)
at ../../cc/animation/worklet_animation.cc:83
#7 0x000000000b08a84e in cc::AnimationHost::CollectWorkletAnimationsState(base::TimeTicks, cc::ScrollTree const&, bool) (this=0x2b1f0b
on the compositor thread, looking for elementID 74 in the pending tree
,
Jun 25 2018
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b0eaa875393a65c125e1f278a45b90d202aa807 commit 3b0eaa875393a65c125e1f278a45b90d202aa807 Author: Peter Mayo <petermayo@chromium.org> Date: Thu Jul 05 22:45:43 2018 [BGPT] Create scroll nodes for ScrollTimeline scroll-sources AnimationWorklet currently relies on property trees having a ScrollNode for composited scrollers even when they don't actually scroll overflow, so that it can have a cc::ScrollTimeline based off of them. This CL alters the BlinkGenPropertyTrees scroll-node creation logic to create such a node. Bug: 855718 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I135cc1ace6511315a863638b5ee824ccac88ecb3 Reviewed-on: https://chromium-review.googlesource.com/1114121 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#572865} [modify] https://crrev.com/3b0eaa875393a65c125e1f278a45b90d202aa807/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/3b0eaa875393a65c125e1f278a45b90d202aa807/third_party/blink/renderer/core/animation/scroll_timeline.cc [modify] https://crrev.com/3b0eaa875393a65c125e1f278a45b90d202aa807/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
,
Jul 10
This issue is fixed now, I assume? Please close if so.
,
Jul 10
Running and passing now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by petermayo@chromium.org
, Jun 22 2018