New issue
Advanced search Search tips

Issue 855700 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ChromeOS swarming builds failing during bot_update

Project Member Reported by dgarr...@chromium.org, Jun 22 2018

Issue description

This failure appears to be hitting all swarming bots.

Sample build:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8942992936430993600


Relevant logs:

===Succeeded in 0.0 mins of git version ===
Using git version 2.17.1.chromium15 / Infra wrapper (infra/tools/git/linux-amd64 @ b83e1ae8c931a5261509cc15d443c2d608f65b15)
Fetching Git checkout
===Running /b/swarming/w/ir/cipd_bin_packages/bin/python -u /b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/git_cache.py populate --ignore_locks -v --cache-dir /b/swarming/w/ir/cache/git https://chromium.googlesource.com/chromiumos/chromite.git ===
In directory: /b/swarming/w/ir/kitchen-workdir
/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite has 2 .pack files, re-bootstrapping if >50
running "git config gc.autodetach 0" in "/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite"
running "git config gc.autopacklimit 0" in "/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite"
running "git config core.deltaBaseCacheLimit 2g" in "/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite"
running "git config remote.origin.url https://chromium.googlesource.com/chromiumos/chromite.git" in "/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite"
running "git config --replace-all remote.origin.fetch +refs/heads/*:refs/heads/* \+refs/heads/\*:.*" in "/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite"
Fetching +refs/heads/*:refs/heads/*
running "git fetch -v --progress origin +refs/heads/*:refs/heads/*" in "/b/swarming/w/ir/cache/git/chromium.googlesource.com-chromiumos-chromite"
POST git-upload-pack (994 bytes)
remote: Counting objects: 1           
remote: Counting objects: 1842, done        
remote: Finding sources:  20% (1/5)           
remote: Finding sources:  40% (2/5)           
remote: Finding sources:  60% (3/5)           
remote: Finding sources:  80% (4/5)           
remote: Finding sources: 100% (5/5)           
remote: Finding sources: 100% (5/5)        
remote: Total 5 (delta 2), reused 5 (delta 2)        
From https://chromium.googlesource.com/a/chromiumos/chromite
 = [up to date]          0.11.241.B                  -> 0.11.241.B
 = [up to date]          0.11.257.B                  -> 0.11.257.B
 = [up to date]          0.11.257.B90                -> 0.11.257.B90
 = [up to date]          0.12.362.B                  -> 0.12.362.B
 = [up to date]          0.12.369.B                  -> 0.12.369.B
 = [up to date]          0.12.392.B                  -> 0.12.392.B

<sync logs>


[0:00:00]  = [up to date]          toolchainA              -> origin/toolchainA
[0:00:00]  = [up to date]          toolchainB              -> origin/toolchainB
[0:00:00]  = [up to date]          updCrOSconfig           -> origin/updCrOSconfig
________ running 'git reset --hard HEAD' in '/b/swarming/w/ir/kitchen-workdir/chromite'
[0:00:01] HEAD is now at 6ec076cea gs: Use Stainless log browser everywhere in chromite.
[0:00:01] Attempting rebase onto master:...
[0:00:01] 
[0:00:01] Rebase produced error output:
fatal: Needed a single revision
Does not point to a valid commit: master:
----------------------------------------
Error: 1> Unrecognized error, please merge or rebase manually.
1> cd /b/swarming/w/ir/kitchen-workdir/chromite && git rebase --verbose --onto master: refs/remotes/origin/master
===Failed in 0.0 mins of /b/swarming/w/ir/cipd_bin_packages/bin/python -u /b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/gclient.py sync --verbose --reset --force --ignore_locks --output-json /b/swarming/w/ir/tmp/tmpos9R1B.json --nohooks --noprehooks --delete_unversioned_trees --revision chromite@master: --revision depot_tools@master:5888d6f676722fdac3f65e673c0232667309296c ===
We failed gclient sync, lets delete the checkout and retry.
.git detected in checkout, deleting /b/swarming/w/ir/kitchen-workdir/depot_tools... Marking for removal /b/swarming/w/ir/kitchen-workdir/depot_tools => /b/swarming/w/ir/kitchen-workdir/recipe_cleanup/bot_update/depot_tools_98e7d7d4e5434be7a13402d589c69863
done
.git detected in checkout, deleting /b/swarming/w/ir/kitchen-workdir/recipe_cleanup... Marking for removal /b/swarming/w/ir/kitchen-workdir/recipe_cleanup => /b/swarming/w/ir/kitchen-workdir/recipe_cleanup/bot_update/recipe_cleanup_a14e2feff27d42b7bab71c59378cceab
Error renaming /b/swarming/w/ir/kitchen-workdir/recipe_cleanup to /b/swarming/w/ir/kitchen-workdir/recipe_cleanup/bot_update/recipe_cleanup_a14e2feff27d42b7bab71c59378cceab: [Errno 22] Invalid argument
Traceback (most recent call last):
  File "/b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1258, in <module>
    sys.exit(main())
  File "/b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1242, in main
    checkout(options, git_slns, specs, revisions, step_text, shallow)
  File "/b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1151, in checkout
    ensure_no_checkout(dir_names, options.cleanup_dir)
  File "/b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 311, in ensure_no_checkout
    remove(deletion_target, cleanup_dir)
  File "/b/swarming/w/ir/kitchen-checkout/scripts/slave/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 296, in remove
    os.rename(target, dest)
OSError: [Errno 22] Invalid argument
step returned non-zero exit code: 1
 
In the command

```git rebase --verbose --onto master: refs/remotes/origin/master```


The trailing full colon after "master" should not be there.
All PreCQ jobs appear to have started failing around 11:30 AM PDT: https://chrome-swarming.appspot.com/tasklist?c=name&c=state&c=created_ts&c=duration&c=pending_time&c=pool&c=bot&et=1529695200000&f=pool%3AChromeOS&l=50&n=true&q=pool%3AChromeOS&s=created_ts%3Adesc&st=1529608800000

Trooper we didn't change anything in our Recipe lately, any idea what's going on? Can you help?
Labels: -Pri-3 OS-Chrome Pri-0
Components: Infra
Labels: Infra-Troopers

Comment 6 by h...@google.com, Jun 22 2018

Labels: Infra-DX
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Labels: -Infra-Troopers -Infra-DX Foundation-Troopers
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/565fa6a4078091814163e8449609619953545947

commit 565fa6a4078091814163e8449609619953545947
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Jun 22 19:50:46 2018

Revert "Wipe out shallow checkout support from bot_update."

This reverts commit 568b7a8998b127cb5e34149cd63e9b16fe823a40.

Reason for revert: temporary revert to revert previous CL.

Original change's description:
> Wipe out shallow checkout support from bot_update.
> 
> Bug:  855137 
> Change-Id: I60b8d69f9ab353c12120d4216e3a12518f99732c
> Reviewed-on: https://chromium-review.googlesource.com/1111107
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>

TBR=iannucci@chromium.org,hinoka@chromium.org,tandrii@chromium.org

Change-Id: Iede67717be448be9bdd7c5dd4895fbab9fd65c66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  855137 ,  855700 
Reviewed-on: https://chromium-review.googlesource.com/1111924
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[add] https://crrev.com/565fa6a4078091814163e8449609619953545947/recipes/recipe_modules/bot_update/examples/full.expected/shallow.json
[modify] https://crrev.com/565fa6a4078091814163e8449609619953545947/tests/bot_update_coverage_test.py
[modify] https://crrev.com/565fa6a4078091814163e8449609619953545947/recipes/recipe_modules/bot_update/examples/full.py
[modify] https://crrev.com/565fa6a4078091814163e8449609619953545947/recipes/README.recipes.md
[modify] https://crrev.com/565fa6a4078091814163e8449609619953545947/recipes/recipe_modules/bot_update/api.py
[modify] https://crrev.com/565fa6a4078091814163e8449609619953545947/recipes/recipe_modules/bot_update/resources/bot_update.py

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/612d62d0cacf15e89fb9bd14f10ab91c9adde442

commit 612d62d0cacf15e89fb9bd14f10ab91c9adde442
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Jun 22 19:50:56 2018

Revert "bot_update: Don't force solutions to be unmanaged."

This reverts commit c48318a35b173ee25ca65de6910b88e918b84dec.

Reason for revert: likely broke ChromeOS

Original change's description:
> bot_update: Don't force solutions to be unmanaged.
> 
> gclient should be the one syncing the solutions to the appropriate
> revisions.
> 
> Bug: 850812, 853032
> Change-Id: Ieefc5661627d4864deb0d4e7053168a99da29d29
> Reviewed-on: https://chromium-review.googlesource.com/1102833
> Reviewed-by: Aaron Gable <agable@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=hinoka@chromium.org,agable@chromium.org,ehmaldonado@chromium.org

Change-Id: I7e110108a9687d703ea8be39cc83e0888f7813c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850812, 853032,  855700 
Reviewed-on: https://chromium-review.googlesource.com/1111925
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/612d62d0cacf15e89fb9bd14f10ab91c9adde442/recipes/recipe_modules/bot_update/resources/bot_update.py
[modify] https://crrev.com/612d62d0cacf15e89fb9bd14f10ab91c9adde442/tests/bot_update_coverage_test.py

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b9ab0377c481451a8ecb6004c80f3750ea59ee12

commit b9ab0377c481451a8ecb6004c80f3750ea59ee12
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Jun 22 19:53:25 2018

Revert "Roll recipe dependencies (trivial)."

This reverts commit f5bdafdb068d5dafa6701be2ac5a0466b53c2f9d.

Reason for revert: undoing for 855700

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> depot_tools:
>   https://crrev.com/568b7a8998b127cb5e34149cd63e9b16fe823a40 Wipe out shallow checkout support from bot_update. (tandrii@chromium.org)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I2f5c63383e7ea08ab41198184e81f90d411e3a03
> Reviewed-on: https://chromium-review.googlesource.com/1112470
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: Ib0fb31956296ddc25c4d096ae19f428b3a2a07eb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  855700 
Reviewed-on: https://chromium-review.googlesource.com/1111927
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/b9ab0377c481451a8ecb6004c80f3750ea59ee12/scripts/slave/README.recipes.md
[modify] https://crrev.com/b9ab0377c481451a8ecb6004c80f3750ea59ee12/infra/config/recipes.cfg

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/eeaaf008ce602e409641e9c17b557d131da8a92c

commit eeaaf008ce602e409641e9c17b557d131da8a92c
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Fri Jun 22 19:53:52 2018

Revert "Roll recipe dependencies (trivial)."

This reverts commit fdb98accd057135662c36845e5e9197fffc60999.

Reason for revert: likely broke ChromeOS

Original change's description:
> Roll recipe dependencies (trivial).
> 
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
> 
> 
> More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
> depot_tools:
>   https://crrev.com/c48318a35b173ee25ca65de6910b88e918b84dec bot_update: Don't force solutions to be unmanaged. (ehmaldonado@chromium.org)
> 
> 
> TBR=iannucci@chromium.org
> 
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I489ddfdafd5cc6c3f720929bc69e23b8a43b48fa
> Reviewed-on: https://chromium-review.googlesource.com/1112461
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

TBR=iannucci@chromium.org,recipe-roller@chromium.org

Change-Id: I2a95695f3b8ef487ccf59c11ed4dca6a410561e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  855700  
Reviewed-on: https://chromium-review.googlesource.com/1111926
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/eeaaf008ce602e409641e9c17b557d131da8a92c/scripts/slave/README.recipes.md
[modify] https://crrev.com/eeaaf008ce602e409641e9c17b557d131da8a92c/infra/config/recipes.cfg

Cc: ehmaldonado@chromium.org
I think it should recover now.
Our outage started about 1.5 hours ago and at least two of those changes that were reverted were landed after that.
I don't actually see 1.5 hours ago builds, can you point me out to them?
Status: Fixed (was: Assigned)
Confirmed that builds are starting correctly now.
Labels: -Foundation-Troopers
Owner: ehmaldonado@chromium.org
Status: Assigned (was: Fixed)
ehmaldonado@ your CL broke our recipe and thus broke most ChromeOS builds. The question is.... what can/should we do to avoid being broken in future?
Labels: -Pri-0 Pri-1
Wait, no, those started before the attempted fix; ignore.
Notice the start time on that build. It was 12:11.
https://chrome-swarming.appspot.com/task?id=3e41b185b3829610&refresh=10 is the first build failure that we saw with this symptom. So, more like an hour. Sorry for the confusion.
Components: -Infra Infra>Platform
Project Member

Comment 26 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bee76eb1685337262ac8f43ad401dc7b72d6200

commit 5bee76eb1685337262ac8f43ad401dc7b72d6200
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 22 22:59:09 2018

Roll src/third_party/depot_tools c48318a35b17..08d753e88484 (4 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c48318a35b17..08d753e88484


git log c48318a35b17..08d753e88484 --date=short --no-merges --format='%ad %ae %s'
2018-06-22 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-22 tandrii@chromium.org Revert "bot_update: Don't force solutions to be unmanaged."
2018-06-22 tandrii@chromium.org Revert "Wipe out shallow checkout support from bot_update."
2018-06-22 tandrii@chromium.org Wipe out shallow checkout support from bot_update.


Created with:
  gclient setdep -r src/third_party/depot_tools@08d753e88484

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:850812,chromium:853032, chromium:855700 , chromium:855137 , chromium:855700 , chromium:855137 
TBR=agable@chromium.org

Change-Id: I9f3c95031934c4be4cbdb53960a09bd707f61bc6
Reviewed-on: https://chromium-review.googlesource.com/1112227
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569820}
[modify] https://crrev.com/5bee76eb1685337262ac8f43ad401dc7b72d6200/DEPS

Status: Fixed (was: Assigned)
Other than writing more tests for bot_update, I don't know.

Filed crbug.com/855786 to track efforts to mitigate breakages caused by depot_tools changes.
A doc is linked in there as well.

Sign in to add a comment